288728 - NSSCMSRecipientID_BrandNew not handled in nss_cms_recipients_traverse

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Julien Pierre]

IMO, the following compiler warning warrants its own a bug. I'm not sure what
the correct handling is for this case.

cmsreclist.c: In function `nss_cms_recipients_traverse':
cmsreclist.c:85: warning: enumeration value `NSSCMSRecipientID_BrandNew' not
handled in switch

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

I think the fix is to add a "default" case to that
switch statement and handle that as invalid input.

NSSCMSRecipientID_BrandNew is only used as an argument
to nss_cmsrecipientinfo_create, but nss_cmsrecipientinfo_create
doesn't store the NSSCMSRecipientID_BrandNew value anywhere.
Also, the value of NSSCMSRecipientID_BrandNew is 2, so
if any structure field of the type NSSCMSRecipientIDSelector
is initialized to 0 (by a PORT_ZAlloc or PORT_ArenaZAlloc
call) and not assigned a value, its value will be
NSSCMSRecipientID_IssuerSN (0).

While doing the code review, I fixed two assertions in cmsrecinfo.c
to use a whitelist instead of a blacklist.

Comment 2

[Robert Relyea]

Comment on attachment 196219 [details] [diff] [review]
Proposed patch

sr=relyea

Comment 3

[Wan-Teh Chang]

Patch checked in on the NSS trunk for NSS 3.11.