288857 - Use of uninitialized value in bitwise and (&) at Bugzilla/User.pm line 984.

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Max Kanat-Alexander]

[Sun Apr 03 10:05:36 2005] [error] [client 216.233.210.105] [Sun Apr  3 10:05:36
 2005] process_bug.cgi: Use of uninitialized value in bitwise and (&) at Bugzill
a/User.pm line 984., referer: http://landfill.bugzilla.org/mkanat/show_bug.cgi?i
d=2323

That's the second line of this:

>    if ($wants_mail && $changer && ($self->{'login'} eq $changer)) {
>        $wants_mail &= $self->wants_mail([EVT_CHANGED_BY_ME], $relationship);
>    }

Comment 1

[Max Kanat-Alexander]

I'm pretty sure that this can be reproduced just by submitting any change to a
bug, as I recall.

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This fixes the problem. If there were no matches in the SQL, we were getting
undef rather than 0.

Gerv

Comment 3

[Frédéric Buclin]

Comment on attachment 179627 [details] [diff] [review]
Patch v.1

>+    $wants_mail ||= 0;
>     
>     return($wants_mail);
>

what is returned if the SQL request is successful? You say it return 'true'.
Then you should write:
return defined($wants_mail) ? 1 : 0;

Denying review unless you have a good reason to fix it this way.

Comment 4

[Frédéric Buclin]

Gerv, wants_mail() gives no other information except "yes/no", "true/false",
right? If so, could you please update your patch considering my previous comment?
My log file is full of this error message and makes me very angry!

Comment 5

[Gervase Markham [:gerv]]

Attachment: Patch v.2

Here you go :-)

Gerv

Comment 6

[Frédéric Buclin]

Comment on attachment 180201 [details] [diff] [review]
Patch v.2

r=LpSolit

Comment 7

[Frédéric Buclin]

Gerv, I did the checkin myself. I couldn't wait anymore to see this message out
of my log file. :)


Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.54; previous revision: 1.53
done