Implicit joins should be replaced by explicit joins - installment C

RESOLVED FIXED in Bugzilla 2.20

Status

()

--
enhancement
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: Tomas.Kopal, Assigned: Tomas.Kopal)

Tracking

2.19.2
Bugzilla 2.20
Dependency tree / graph
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

5.13 KB, patch
bugreport
: review+
Details | Diff | Splinter Review
(Assignee)

Description

14 years ago
This is a followup to bug 286235, dealing with the more joins that needs to be
converted (aka part 3 of the patch from bug 286235).
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

14 years ago
Posted patch V2 (obsolete) — Splinter Review
This is just un-bitrotten part 3 of the patch from bug 286235.
Attachment #179642 - Flags: review?(bugreport)
(Assignee)

Updated

14 years ago
Attachment #179642 - Flags: review?(bugreport)
(Assignee)

Comment 2

14 years ago
Posted patch V2.1Splinter Review
As Max requested due to the fact we are in freeze, I have removed all changes
from implicit to explicit JOINs which are currently purely implicit. The patch
is much smaller now and it will (hopefully) still work on postgres.
Just for the record, I still think that converting all implicit JOINs to
explicit ones is a good think to do and I promise I will try again after the
freeze :-).
(Assignee)

Updated

14 years ago
Attachment #179642 - Attachment is obsolete: true
Attachment #179903 - Flags: review?(bugreport)

Updated

14 years ago
Attachment #179903 - Flags: review?(bugreport) → review+
(Assignee)

Updated

14 years ago
Flags: approval?
Flags: approval? → approval+
Target Milestone: --- → Bugzilla 2.20
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.81; previous revision: 1.80
done
Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.88; previous revision: 1.87
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.322; previous revision: 1.321
done
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.114; previous revision: 1.113
done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Updated

14 years ago
Severity: normal → enhancement
Version: unspecified → 2.19.2

Updated

14 years ago
Blocks: 314454
You need to log in before you can comment on or make changes to this bug.