28906 - Mac NSPR socket function changes due to PRNetAddr's new ipv6 member

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Wan-Teh Chang]

In NSPR 4.0, the PRNetAddr union has a new 'ipv6' member
for IPv6 socket addresses.  Therefore, the size of PRNetAddr
increased from 16 bytes to 28 bytes on the Mac.

Some of the Mac NSPR socket functions in
mozilla/nsprpub/pr/src/md/mac/macsockotpt.c need
to be updated to reflect the larger size of PRNetAddr
in NSPR 4.0.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch.

Comment 2

[Wan-Teh Chang]

Attachment: Revised patch.

Comment 3

[Jim Roskind]

Wtc indicated this is a stopper for SSL on Mac.  That is the justification for 
the beta1 marking.

Comment 4

[leger]

Putting on PDT+ radar for beta1.

Comment 5

[Wan-Teh Chang]

The revised patch (attachment 5630 [details] [diff] [review]) is checked in on
the NSPRPUB_RELEASE_4_0_BRANCH.

/cvsroot/mozilla/nsprpub/pr/src/md/mac/macsockotpt.c, revision 3.14.8.3

Comment 6

[Mark Welch]

This has been checked in for a while. Do I need to track the progress of this 
bug for Mac SSL?

Comment 7

[Jim Roskind]

Wan Teh: When will this be closed out??  I'd like to get this off the radar.
Please put the landing date in the status whiteboard (or mark this closed if we 
have taken the change).
Thanks,
Jim

Comment 8

[Wan-Teh Chang]

This bug fix is in the NSPRPUB_RELEASE_4_0_20000223 tag.
sfraser changed mozilla/build/mac/NGLayoutBuildList.pm, rev. 1.445,
on 2000/02/25 to pull this NSPR tag.