289062 - editusers is querying for groups twice on update

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Tomas Kopal]

Editusers.cgi is selecting ids and names of groups on update, but that
information is already available. We can clean this up.
Whis is a followup from bug 286686.

Comment 1

[Tomas Kopal]

Attachment: V1

Sorry, Marc, you have been nominated for review by Max ;-).

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 179661 [details] [diff] [review]
V1

>diff -ru ../bugzilla-clean/editusers.cgi ./editusers.cgi
>--- ../bugzilla-clean/editusers.cgi	2005-03-16 20:17:03.000000000 +1030
>+++ ./editusers.cgi	2005-04-05 12:02:32.638750000 +0930
>@@ -295,7 +295,6 @@
>           });
> 
>     # We need the group names, too -- for display and for profiles_activity.
>-    my $groups = $dbh->selectall_hashref('SELECT id, name FROM groups', 'id');

Please remove the comment as well. Can be done on checkin imo.

Nice clean-up, r=wurblzap.

Comment 3

[Tomas Kopal]

Attachment: V1.1

Removed also the comment, as suggested. Carrying the r+ on.

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 179778 [details] [diff] [review]
V1.1

I'd like to get a second review on this because of the security level of the
code it's touching, since we're in freeze mode now and I'd hate to regress
anything.

Comment 5

[Joel Peshkin]

Comment on attachment 179778 [details] [diff] [review]
V1.1

r=joel
this looks pretty safe

Comment 6

[Frédéric Buclin]

Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.84; previous revision: 1.83
done