Closed Bug 289179 Opened 19 years ago Closed 19 years ago

pgup/pgdown no longer work in textareas

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: roc)

References

()

Details

Attachments

(1 file)

This is a regression from 2005-04-03-06 to 2005-04-04-06.  To reproduce:

1)  Load https://bugzilla.mozilla.org/attachment.cgi?id=179734&action=edit
2)  Click the "Edit Attachment As Comment" button.
3)  Focus the textarea
4)  Hit the "Page down" key.

ACTUAL RESULTS:  Nothing happens

EXPECTED RESULTS: Page down.

This looks somewhat similar to bug 289022, so marking dependent.  In any case,
the scrollframe changes are my initial culprit for this regression.
Flags: blocking1.8b2?
(Also worth testing Shift-PgUp and Shift-PgDn.  It seems a little odd that
something like the scrollframe changes would brake only a subset of keys, so
that may not be the cause.)
Flags: blocking1.8b2? → blocking1.8b2+
Attached patch fixSplinter Review
Just another place making assumptions about scrollframe internals. In this
case, nsTextControlFrame was actually assuming that the scrollframe's scrolling
view was the view for its first child frame.
Assignee: nobody → roc
Status: NEW → ASSIGNED
Attachment #179789 - Flags: superreview?(dbaron)
Attachment #179789 - Flags: review?(dbaron)
Comment on attachment 179789 [details] [diff] [review]
fix

r+sr=dbaron, but since this comes first:

>   first->AddStateBits(NS_FRAME_REFLOW_ROOT);

you clearly don't need any null-checks of |first|.
Attachment #179789 - Flags: superreview?(dbaron)
Attachment #179789 - Flags: superreview+
Attachment #179789 - Flags: review?(dbaron)
Attachment #179789 - Flags: review+
Comment on attachment 179789 [details] [diff] [review]
fix

approving since this didn't make it in yesterday.  Please do try to get this in
soon.
Attachment #179789 - Flags: approval1.8b2+
checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: