Closed Bug 289231 Opened 19 years ago Closed 17 years ago

tracking bug for extensions broken by the fix for bug 281988

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Version:
1.7 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: asa, Assigned: asa)

Details

If you've discovered that the Firefox 1.0.3 builds with the fix for bug 281988
have broken your extension, please add a comment here with the extension hame,
and the JS Console errors (you'll probably want to set
javascript.options.showInConsole to true) that you see for that extension. Thanks.
AdBlock: While trying to add an element to the adblocker, got this error.

Error: data has no properties
Source File: chrome://adblock/content/adblock.js
Line: 898
On the Mac, I can't get Adblock to work properly.

I get the following errors in the JS console:

Error: window._AdblockObjects has no properties
Source File: chrome://adblock/content/component.js
Line: 824

Error: uncaught exception: [Exception... "Component returned failure code:
0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXULTreeBuilder.getResourceAtIndex]" 
nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://adblock/content/filterall.js :: onSelectionChange :: line 191"  data: no]
On Windows Xp, the BugMeNot extension (version 0.6.2) no longer works.  When
trying to fill in a username/password by right clicking on the text input and
selecting BugMeNot, the following javascript error is given

Error: window._content.document.location has no properties
chrome://bugmenot/content/bugmenotOverlay.js   Line: 35

BugMeNot fails to fill in the username/password
(In reply to comment #2)
> On the Mac, I can't get Adblock to work properly.
> 
> I get the following errors in the JS console:
> 
> Error: window._AdblockObjects has no properties
> Source File: chrome://adblock/content/component.js
> Line: 824
> 
> Error: uncaught exception: [Exception... "Component returned failure code:
> 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXULTreeBuilder.getResourceAtIndex]" 
> nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
> chrome://adblock/content/filterall.js :: onSelectionChange :: line 191"  data: no]

Also, the list of blockable elements is empty on the Mac, Vlad reports the same
problem on Linux.
(In reply to comment #4)
> (In reply to comment #2)
> > On the Mac, I can't get Adblock to work properly.
> > 
> > I get the following errors in the JS console:
> > 
> > Error: window._AdblockObjects has no properties
> > Source File: chrome://adblock/content/component.js
> > Line: 824
> > 
> > Error: uncaught exception: [Exception... "Component returned failure code:
> > 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXULTreeBuilder.getResourceAtIndex]" 
> > nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
> > chrome://adblock/content/filterall.js :: onSelectionChange :: line 191" 
data: no]
> 
> Also, the list of blockable elements is empty on the Mac, Vlad reports the same
> problem on Linux.


Same on windows, following error returned while trying to view blockable elements...

Error: uncaught exception: [Exception... "Component returned failure code:
0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXULTreeBuilder.getResourceAtIndex]" 
nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://adblock/content/filterall.js :: onSelectionChange :: line 191"  data: no]
When logging into Yahoo Mail! and clicking on the "Compose" button, when the
"Compose" page loads the following error occurs

Error: parent.getReplyForwardKind is not a function
Source File:
http://us.f541.mail.yahoo.com/ym/instacompose?navidazizi1112753635090    Line: 299

In Firefox 1.0.2 the error does not appear.  

I think this has to do with the Yahoo address auto-complete function which no
longer works in 1.0.3
Spoofstick. (via wilson wong)

Error: [Exception... "Component returned failure code: 0x80004005
(NS_ERROR_FAILURE) [nsIDOMLocation.hostname]"  nsresult: "0x80004005
(NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://spoofstick/content/spoofstick.js :: getDomainName :: line 112"
data: no]
Source File: chrome://spoofstick/content/spoofstick.js
Line: 112

Error: p has no properties
Source File: chrome://spoofstick/content/spoofstick.js
Line: 106

Error: document.getElementById("popupMenuExchange") has no properties
Source File: chrome://translation/content/popup.js
Line: 50
(via Mark M)

Breaks HTML valadator - error and warning not updating between pages

Breaks Webdeveloper extentions - missing all display changing, but not getting
any javascript error messages
I tested several popular extensions with the 2005040516-1.0.3 test build on Mac
OS X 10.3.8, and a couple had problems.

- Web Developer 0.8 installs fine, but the validator tools don't work. I get the
following js console error:

Error: window.content.document.location has no properties
Source File: chrome://webdeveloper/content/webdeveloper.js
Line: 3495

several other Web Developer tools also didn't work, like showing comments or
cookie information.

- Chatzilla 0.9.67 also installs, but the content window (right pane where
server status and chat messages agppear) always remains blank --this is not a
problem with Firefox 1.0.2. (no js console output seen for this issue.)
Status: NEW → ASSIGNED
I have two extensions that are broken by this. Farkit (available on UMO) and
Farky (not on UMO). The main purpose of both of these is diddling with the
page's content/DOM to do useful things.

Farky seems to sometimes give the following error in the console:

Error: [Exception... "'Permission denied to get property Window.content' when
calling method: [nsIDOMEventListener::handleEvent]"  nsresult: "0x8057001e
(NS_ERROR_XPC_JS_THREW_STRING)"  location: "<unknown>"  data: no]

Both seem to fail silently in other ways, but I have not looked into it farther yet.

These extensions are used by a lot of people in the Fark.com forums, if 1.0.3
suddenly breaks it there will be a crowd of unhappy campers...
All-in-One is bust on WinXP, 1.0.3RC 2005-04-05. JS console text:

Error: [Exception... "Component returned failure code: 0x80004005
(NS_ERROR_FAILURE) [nsIDOMNSDocument.getBoxObjectFor]"  nsresult: "0x80004005
(NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://allinonegest/content/trails.js :: aioStartTrail :: line 50"  data: no]
Source File: chrome://allinonegest/content/trails.js
Line: 50

but all of the gestures are inoperative.
Same set-up, MozFBRH:

Error: window._content.document.body has no properties
Source File: chrome://allowrightclick/content/allowrightclickOverlay.xul
Line: 26
Oops. That was Allow Right Click above. This is MozFBRH:

Error: uncaught exception: [Exception... "Component returned failure code:
0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]"  nsresult:
"0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame ::
chrome://mozfbrh/content/mozfbrh.js :: toggleAutoFillInURLBar :: line 402" 
data: no]
http://netscape.com has this annoying little floating div with headlines. If you
click on one it opens another floater with a short story. When AdBlock is
enabled I can't close that floater -- the provided close button gives an error
on the console about not being able to get the property. If I disable AdBlock
then the button works.
Crashed once opening the Linky context menu, but otherwise Linky appears to work
fine.  TB4877191Z

JS_GetFrameFunctionObject 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/js/src/jsdbgapi.c,
line 770]
nsWindowSH::GetProperty 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/dom/src/base/nsDOMClassInfo.cpp,
line 3519]
XPC_WN_Helper_GetProperty 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp,
line 812]
js_GetProperty 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/js/src/jsobj.c,
line 2768]
JS_GetProperty 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/js/src/jsapi.c,
line 2531]
nsDOMClassInfo::PostCreate 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/dom/src/base/nsDOMClassInfo.cpp,
line 2694]
XPCWrappedNative::GetNewOrUsed 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp,
line 438]
XPCConvert::NativeInterface2JSObject 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/js/src/xpconnect/src/xpcconvert.cpp,
line 1065]
XPCConvert::NativeData2JS 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/js/src/xpconnect/src/xpcconvert.cpp,
line 466]
nsXPCWrappedJSClass::CallMethod 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp,
line 1227]
nsXPCWrappedJS::CallMethod 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp,
line 450]
SharedStub 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp,
line 147]
nsEventListenerManager::HandleEventSubType 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/content/events/src/nsEventListenerManager.cpp,
line 1436]
nsEventListenerManager::HandleEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/content/events/src/nsEventListenerManager.cpp,
line 1516]
nsXULDocument::HandleDOMEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/content/xul/document/src/nsXULDocument.cpp,
line 1261]
nsXULElement::HandleDOMEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/content/xul/content/src/nsXULElement.cpp,
line 2823]
nsXULElement::HandleDOMEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/content/xul/content/src/nsXULElement.cpp,
line 2821]
nsXULElement::HandleDOMEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/content/xul/content/src/nsXULElement.cpp,
line 2821]
nsXULElement::HandleDOMEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/content/xul/content/src/nsXULElement.cpp,
line 2821]
nsXULElement::HandleDOMEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/content/xul/content/src/nsXULElement.cpp,
line 2821]
nsXULElement::HandleDOMEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/content/xul/content/src/nsXULElement.cpp,
line 2821]
nsXULElement::HandleDOMEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/content/xul/content/src/nsXULElement.cpp,
line 2821]
PresShell::HandleEventInternal 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/layout/html/base/src/nsPresShell.cpp,
line 6059]
PresShell::HandleEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/layout/html/base/src/nsPresShell.cpp,
line 5921]
nsViewManager::HandleEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 2326]
nsViewManager::DispatchEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 2066]
HandleEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/view/src/nsView.cpp,
line 77]
nsWindow::DispatchEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 1067]
nsWindow::DispatchMouseEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 5261]
ChildWindow::DispatchMouseEvent 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 5511]
nsWindow::WindowProc 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 1349]
USER32.dll + 0x8709 (0x77d48709)
USER32.dll + 0x87eb (0x77d487eb)
USER32.dll + 0x89a5 (0x77d489a5)
USER32.dll + 0x89e8 (0x77d489e8)
nsAppShell::Run 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/widget/src/windows/nsAppShell.cpp,
line 159]
nsAppShellService::Run 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/xpfe/appshell/src/nsAppShellService.cpp,
line 495]
main 
[d:/builds/tinderbox/Fx-Aviary1.0.1/WINNT_5.0_Depend/mozilla/browser/app/nsBrowserApp.cpp,
line 58]
kernel32.dll + 0x16d4f (0x7c816d4f)
Got error shutting a browser window. Came up twice, and I had two tabs

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://browser/content/browser.js :: Shutdown :: line 832"  data: no]

Because of pre-processing, line 832 works out to be
http://lxr.mozilla.org/aviary101branch/source/browser/base/content/browser.js#902
Maybe it's just me, but things seems really sluggish. Even downloading seemed
like I was getting a transfer rate much much lower than usual.
Testing "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7)
Gecko/20050405 Firefox/1.0.3" on few extensions I use, I found following:

* Many features (CSS style viewing, CSS style information, View form information
and so on...) of Web Developer 0.9.3 are broken (no errors in console.)

* TargetAlert 0.7.4 is broken (doesn't work at all, no errors in concole.)

* LiveHTTPheaders 0.10 work, but it keeps on giving following console errors:

Error: Components is not defined
Source File: chrome://livehttpheaders/content/LiveHTTPHeaders.js
Line: 427

* Google PageRank Status works, but keeps on giving following console errors:

Error: window._content has no properties
Source File: chrome://pagerankstatus/content/pagerankstatusOverlay.js
Line: 329

* Download Manager Tweak, AdBlock, User Agent Switcher and SessionSaver seem to
work perfectly. Tested no other extensions.
All-in-one gestures give some errors on closing tabs, but the extension still works:

Error: window._content has no properties
Source File: chrome://pagerankstatus/content/pagerankstatusOverlay.js
Line: 329

Error: window._content has no properties
Source File: chrome://pagerankstatus/content/pagerankstatusOverlay.js
Line: 329

Error: this.docShell has no properties
Source File: chrome://global/content/bindings/browser.xml
Line: 0

Error: this.docShell has no properties
Source File: chrome://global/content/bindings/browser.xml
Line: 0
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.7) Gecko/20050405
Firefox/1.0.3

BugMeNot gives some warnings on fetching user/password, but it still works:

Error: e has no properties
Source File: chrome://bugmenot/content/bugmenotOverlay.js
Line: 1146

Error: window._content has no properties
Source File: chrome://pagerankstatus/content/pagerankstatusOverlay.js
Line: 329

Error: this.docShell has no properties
Source File: chrome://global/content/bindings/browser.xml
Line: 0

I've removed some duplicate entries.
flashblock doesnt work for me anymore
even if i disable it flash doesnt work anymore

if i start firefox in safe mode it works
I tink that Add Bookmark Here 0.5.3 is broken... (did not work since 1.0.3 is
installed) Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.7)
Gecko/20050404 Firefox/1.0.3 on Win2k Pro
Spoofstick 1.05 

rawDomain has no properties Line 138
p has no properties line 124

Adblock 0.5.2+

node has no properties line 885

Error: [Exception... "'adblockEMLoad: TypeError: adblockEntry has no properties'
when calling method: [nsIDOMEventListener::handleEvent]"  nsresult: "0x8057001e
(NS_ERROR_XPC_JS_THREW_STRING)"  location: "<unknown>"  data: no]
not only is flashblock not working anymore (see above)
but after deinstalling it flash still doesnt work anymore -
even after reinstalling flash plugin
works in firefox safemode though

could it have to do with adblock though? get the same javascript errors
like other ppl in this thread
Are there tbird 1.03 branch builds with the fix? If i'm reading this right, this
is going to break BiDi Mail UI...
The content blocker for FireSpook 1.0 (aka MultiZilla for Mozilla Firefox) is
broken by this patch. It displays something like; error: aWindow has no
properties in line x if I remember it correctly.
Error: invalid return
Source File: http://www.thepparatlodge.com/js/all.js
Line: 6, Column: 52
Source Code:
  if(!x && d.getElementById) x=d.getElementById(n); return x;
downTHEMall!: dosn't  work for me. I get an error message saying "Download
XXX.jpg failed."

Error: e has no properties
Source File: chrome://bugmenot/content/bugmenotOverlay.js
Line: 1146
While the devs argue the (de)merits of the fix for bug 281988 in that space, we
talk about broken extensions here.  What I am wondering is there a bug for
broken web sites or web applications caused by that fix?  

It seems to me that the fix for bug 281988 also breaks many web site that use
navigation aids in child windows or in iframes to control content in the parent
window through something like "parent.location=new_page.htm".  I'm seeing the
same sort of JS console errors for those broken web site navigation aids as
those reported for broken extensions here.

Is anyone else noticing this?  Does such a bug regarding broken web site/web
applications exist?
No sites should break because of this. If they do, that should probably be
raised in bug 281988, as that is not the intent of the patch (while breaking the
currently-insecure extensions effectively is).
I noticed that my extension is now reporting lots of "has no properties". In the
past if I wanted to add a new property to an existing object, I could simply
assign to it. For example:

var theBody = rootDocument.getElementsByTagName('body').item(0);
theBody.myExtensionNameHereMarked = true;

But now the assignment to add the new property generates "theBody has no
properties". It would appear that JavaScript is evaluating the lvalue before its
assigned and reporting an error for a non-existant property that i'm trying to
bring into existance. Does that make sense?
Ignore my last comment. My analysis was wrong it would seem. It appears that I
was dereferencing at certain times a null value, without having checked for it
first.

Link Toolbar 0.9.1 is now broken with FF1.0.3
closable?
last comment ~2yrs ago
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → WORKSFORME
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.