289322 - [FIXr]Is the BF_PARSER_CREATING check in nsHTMLInputElement::BindToTree needed?

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

I think the check can be removed... see XXX comment in the code.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Yep, it can go away

We had this check because we could get SetDocument() called before all the
attrs were in place, which would lead to unnecessary thrashing during parsing. 
Since we now always BindToTree after all attrs have been added, this is no
longer an issue.  We can move this code out of DoneCreatingElement and just
call AddedToRadioGroup from BindToTree.  Note that it's OK that we pass PR_TRUE
as aNotify there, since AddedToRadioGroup deals with that.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 179885 [details] [diff] [review]
Yep, it can go away

Wow, this stuff is complex. I suspect that a lot more code can be removed, but
it'll require more investigation and can be done elsewhere.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 179885 [details] [diff] [review]
Yep, it can go away

sr=jst

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 179885 [details] [diff] [review]
Yep, it can go away

This removes some unneeded code.  Should be pretty safe...

Comment 5

[chris hofmann]

Comment on attachment 179885 [details] [diff] [review]
Yep, it can go away

a=chofmann

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed.