If you look in RecreateFramesForContent here: http://lxr.mozilla.org/mozilla/source/layout/base/nsCSSFrameConstructor.cpp#11622 you'll notice that 'parent' is always null, and the value of 'frame' is unused. Indeed, digging through CVS blame, a couple of years ago I changed "parent =" to "frame =" during deCOMtamination. No-one's noticed any bugs due to this since, certainly not with scrollbar parenting which is why I introduced this code in the first place (switching to listboxes/comboboxes to nsGfxScrollFrame). So I say we just rip it out.
Created attachment 179911 [details] [diff] [review] fix In fact we don't need that parameter to ContentInserted at all. Note that this is risk-free since we're not changing the behaviour at all. The only risk is that two years ago I introduced a bug that's still out there that might be fixed if we re-enabled this code. I doubt it.
Comment on attachment 179911 [details] [diff] [review] fix r+sr=bzbarsky. This was probably meant as an optimization, but I doubt that it's worth it even then.
13 years ago
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.