289467 - MailNews should not use simple-uri

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

See URL field - this could should probably just use nsIWebNavigation::loadURI,
or if it does want to use a URI object, it should get one from the IO service...
(using NS_NewURI, for example).

Comment 1

[Serge Gautherie (:sgautherie)]

<http://mxr.mozilla.org/mozilla/search?string=simple-uri&case=on&filter=%5E%5B%5E%5C0%5D*%24&tree=mozilla>
{{
Found 6 matching lines in 6 files

/extensions/venkman/js/venkman-service.js
    * line 61 -- const SIMPLEURI_CTRID = "@mozilla.org/network/simple-uri;1";

/mailnews/base/src/nsMsgWindow.cpp
    * line 460 -- nsCOMPtr <nsIURI> uri = do_CreateInstance("@mozilla.org/network/simple-uri;1", &rv);

/netwerk/test/unit/test_protocolproxyservice.js
    * line 66 -- var uri = Components.classes["@mozilla.org/network/simple-uri;1"]
/netwerk/protocol/viewsource/src/nsViewSourceHandler.cpp
    * line 103 -- // put back our scheme and construct a simple-uri wrapper
/netwerk/build/nsNetCID.h
    * line 107 -- "@mozilla.org/network/simple-uri;1"

/testing/performance/win32/base_profile/compreg.dat
    * line 1234 -- @mozilla.org/network/simple-uri;1,{e0da1d70-2f7b-11d3-8cd0-0060b0fc14a3}
}}

Comment 2

[Boris Zbarsky [:bzbarsky]]

Every single one of those except nsMsgWindow is correct (which means that comment is mostly noise).

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Use nsIWebNavigation::LoadURI instead. 

The sequence described in a comment at http://lxr.mozilla.org/seamonkey/source/mailnews/news/src/nsNNTPProtocol.cpp#2314 still seems to apply. (would it be clearer if it read nsIWebNavigation?).

Comment 4

[David :Bienvenu]

Comment on attachment 324514 [details] [diff] [review]
proposed fix

the other use of this is to display text when the user is offline but we don't have the message body locally.

Comment 5

[Magnus Melin [:mkmelin]]

Checking in mailnews/base/src/nsMsgWindow.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMsgWindow.cpp,v  <--  nsMsgWindow.cpp
new revision: 1.106; previous revision: 1.105
done

->FIXED

Note for testers: the message in the message body for messages not available offline, and the one shown to remove expired articles in news should work like before.