Closed Bug 28973 Opened 25 years ago Closed 24 years ago

the editor UI needs to handle illegal document types

Categories

(Core :: DOM: Editor, defect, P3)

Product:
Core
Component:
DOM: Editor
Platform:
x86
Windows NT
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: buster, Assigned: sfraser_bugs)

Details

(Whiteboard: [nsbeta2+][6/01] will verify using 5/30 build.) 

split off from PDT+ bug 14599

I've written code to detect when the user attempts to edit a frameset document.  
But I don't know what to do with that knowledge.  We can pop up a dialog, shut 
down the window, leave the window up but not editable, ...

Sounds like a job for the editor UI team, both to decide what ought to be done, 
and to code it up.
marked beta1 because it's split off from a PDT+ bug
Keywords: beta1
Status: NEW → ASSIGNED
Target Milestone: M14
Putting on PDT- radar for beta on the element of the problem.
Whiteboard: [PDT-]
Hold on please! You accepted fixing bug 14599, which will close the window
when a FRAMESET is encountered, but without any notification to the user.
All Steve is requesting here is to add a single line of code to popup a 
messagebox to the user to tell them why we are not allowing editing.
Also required is adding one string to editor.properties, which is the 
actual string displayed to the user. Shouldn't we tell the user why we aren't
allowing them to edit?
Removing PDT- for reevaluation.
Whiteboard: [PDT-]
Excessive polish.  sorry, relnote for beta1.  sujay, put text for release note 
in http://bugzilla.mozilla.org/show_bug.cgi?id=25524.  Setting to pdt-
Keywords: relnote
Whiteboard: [PDT-]
Will add UI part in M15.
For the record, objection to "excessive polish" claim is noted.
Target Milestone: M14 → M15
Simon has fixed this - I'll let him close it out.
Assignee: cmanske → sfraser
Status: ASSIGNED → NEW
M16
Target Milestone: M15 → M16
M17
Target Milestone: M16 → M17
This is more serious than is sounds. You can open a JPEG file in the editor on 
Mac, start editing, then save, and it will nuke the contents of the JPEG.

Nominating for beta2.
Status: NEW → ASSIGNED
Keywords: beta1, relnote → nsbeta2
Whiteboard: [PDT-]
Putting on [nsbeta2+][6/01] radar.  This work must be done by 06/01 or we may 
pull this for PR2.

Is the frame problem resolved?
Whiteboard: [nsbeta2+][6/01]
m16
Target Milestone: M17 → M16
Fix checked in. If the MIME type is not text/html or text/plain, we put up a 
dialog to alert the user, then close the window.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
 will verify using 5/30 build.
Whiteboard: [nsbeta2+][6/01] → [nsbeta2+][6/01] will verify using 5/30 build.
verified in 5/30 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.