Closed Bug 28974 Opened 25 years ago Closed 4 years ago

"Edit Page" should disable if page is a frameset or xml document

Categories

(Core :: DOM: Editor, enhancement, P3)

Product:
Core
Component:
DOM: Editor
Type:
enhancement

Tracking

()

Status:
RESOLVED WONTFIX
Milestone:
Future

People

(Reporter: buster, Unassigned)

References

Details

(Keywords: helpwanted) 

we should be able to detect what type of content is loaded in the browser, and 
dynamically enable/disable the "Edit Page" command.  "Edit Page" should be 
disabled for frameset documents and xml documents.  Preventing the user from 
trying to edit an illegal document type is much better workflow than letting 
them pop up a new window, only to be told "sorry chuckles, not on my watch"
nominated for beta1 because it was split off from pdt+ bug 14599.
Keywords: beta1
shorten summary
note: for framesets, if a frame is selected we should allow "Edit Frame" rather
than disable as buster describes above.  This is compatible with how frames were
edited in 4.x
OS: Windows NT → All
Hardware: PC → All
Summary: the browser "Edit Page" action should be disabled if the current document loaded in the browser is a frameset or xml document → "Edit Page" should disable if page is a frameset or xml document
Putting on PDT+- radar for beta.
Component: Browser-General → Editor
QA Contact: asadotzler → sujay
Whiteboard: [PDT-]
Do we crash if we do not disable?  if so, remove PDT-.
no, we do not crash.  we used to, but that portion of this problem was fixed 
long ago.  today, the user gets an editor window with no editing ability.  it's 
very confusing, especially because it might not be clear to the user that they 
have a frameset or xml document and that is why they get no response.
Putting on relnote for no response issue.  PDT- call made with rickg present.
Keywords: relnote
Target Milestone: M15
Bug 14599 exists to deal gracefully with frameset documents, though this will 
probably work by putting up a dialog after we attempt to load the page. This bug 
is thus an RFE to disable the menu item up-front, which is harder. Thus M20.
Status: NEW → ASSIGNED
Summary: "Edit Page" should disable if page is a frameset or xml document → [RFE] "Edit Page" should disable if page is a frameset or xml document
Whiteboard: [PDT-]
Target Milestone: M15 → M20
Putting on PDT- radar for beta1.  Will relnote.
Whiteboard: [PDT-]
moving to future
Target Milestone: M20 → Future
adding help wanted keyword
Keywords: beta1, relnote → helpwanted
Whiteboard: [PDT-]
*** Bug 61155 has been marked as a duplicate of this bug. ***
Comment reported from duped bug 61155:

"Similarly, if you right click on, for example, links to .exe or .zip 
files and choose Edit Link in Composer,  Composer opens, scolds you, and 
closes."
[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.
Severity: normal → enhancement
Summary: [RFE] "Edit Page" should disable if page is a frameset or xml document → "Edit Page" should disable if page is a frameset or xml document
QA Contact: sujay → editor
Assignee: sfraser_bugs → nobody
This is a mass change. Every comment has "assigned-to-new" in it.

I didn't look through the bugs, so I'm sorry if I change a bug which shouldn't be changed. But I guess these bugs are just bugs that were once assigned and people forgot to change the Status back when unassigning.
Status: ASSIGNED → NEW

Since there is no "Edit page" on the browser as of now, I don't think we want to work on this.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.