289933 - new Script objects are callable but report typeof object instead of function

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

1.7 builds report typeof (new Script()) as 'function', but 1.8 builds report
'object'.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

Shaver tells me that Script does implement [[Call]], and so by the table in
11.4.3, typeof should, in fact, be returning "function". The regression is from
bug 246441. Brendan, why was the older version (just checking clasp->call !=
NULL) insufficient? This patch just fixes 'typeof(new Script())'.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

IE reports |typeof /a/| as "object". I'm not sure if we want to dogmatically
stick to the spec here, or go for an (arguably more intuitive) interpretation
and emulate IE.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: just functions are functions

patch v1 calls all of: regexps, scripts (in the new Script() sense), and
functions  "function".
this patch calls only functions "function". I'll also attach a patch that makes
scripts and functions "function".

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: scripts and functions are functions

This makes regexps "object", script and functions "function".

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

For the record: I tested IE, Opera, and Safari, and all three browsers report
|typeof /a/| as being "object". Since Script is one of our things, we can do
whatever we want with it, which is why I've attached all 3 versions of the patch.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Also note bug 61911.

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 186837 [details] [diff] [review]
just functions are functions

I'll try to get ECMA TG1 to specify this in a future Edition.

/be

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in.

Comment 9

[Bob Clary [:bc] (inactive)]

test in js1_3/Script/script-001.js

Comment 10

[Alex Fritze]

Can we please back this out again?

This patch breaks a ton of my sip code (http://www.croczilla.com/zap) which for
one reason or another needs to discriminate between objects and regexps.
I don't know how common this pattern is, but silently changing the behavior
without bumping the JS version is likely to lead to confusion more than anything
else.

Even the checkin comment is confused about what behaviour we now implement:

revision 3.211
date: 2005/07/16 02:03:26;  author: mrbkap%gmail.com;  state: Exp;  lines: +1 -3
bug 289933: make regexps and script objects be of type 'function' to imitate IE.
r+a=brendan

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

Yeah, I kind of botched that checkin message. I think backwards compat. with
Firefox 1.0.x might take precedence over compat. with other browsers. Brendan,
this would suggest that RegExp and Script should both be functions. What do you
think?

Comment 12

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: functions, script objects, and regular expressions are functions

Comment 13

[Brendan Eich [:brendan]]

Comment on attachment 192852 [details] [diff] [review]
functions, script objects, and regular expressions are functions

No need to over-parenthesize the || expression. Also, I'm guessing that dynamic
frequency of function object operand to typeof is higher than other classes, so
transpose the || operands. Finally, how about a comment before the clasp =
OBJ_GET_CLASS(cx, obj) line that starts the block, talking about ECMA [[Call]]
and citing chapter and verse?

Fix those and r+a=me, thanks!

/be

Comment 14

[Blake Kaplan (:mrbkap) (inactive)]

Checked into MOZILLA_1_8_BRANCH and trunk. RegExps, Scripts, and functions are
all of type "function" now.

Comment 15

[Scott MacGregor]

FYI, this change broke view source after a form submission. See Bug 305959 for
details.