289999 - $bad_names hash in index-renaming code throws an "odd number of elements" warning

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P2)

Description

[Max Kanat-Alexander]

When I was coding for bug 78276, I realized that instead of having the
$bad_names hash keys point to a list, they need to point to an arrayref. It
seems like perl is interpreting my list as additional key/value pairs.

Comment 1

[Max Kanat-Alexander]

The only actually bad effect of this bug is that people who were using CVS might
not have had one or two indexes renamed properly.

It won't affect any released version.

Comment 2

[Max Kanat-Alexander]

Attachment: Fix the hash to use arrayrefs instead of lists (use -p1) (requires bug 78276)

Hey Jouni. This is a pretty straightforward patch, and you reviewed the
original code. Care to take a look at this one?

Comment 3

[Max Kanat-Alexander]

Attachment: Change to have no dependencies

OK, I decided that I'd rather just have this patch in, because it makes stuff
broken, and I want to fix that *before* modifying the code in any other way.
:-)

Comment 4

[:glob ✱]

Comment on attachment 180682 [details] [diff] [review]
Change to have no dependencies

r=glob by inspection

Comment 5

[Max Kanat-Alexander]

Checking in Bugzilla/DB/Mysql.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Mysql.pm,v  <--  Mysql.pm
new revision: 1.12; previous revision: 1.11
done