Closed
Bug 290090
Opened 18 years ago
Closed 17 years ago
Meta refresh should pass VALIDATE_ALWAYS instead of LOAD_BYPASS_CACHE
Categories
(Core :: DOM: Navigation, defect, P2)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: darin.moz, Assigned: darin.moz)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
2.46 KB,
patch
|
Biesinger
:
review+
bzbarsky
:
superreview+
bzbarsky
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
Meta refresh should pass VALIDATE_ALWAYS instead of LOAD_BYPASS_CACHE For some reason meta refreshes of more than 15 seconds set LOAD_BYPASS_CACHE when triggering the new page load. That seems really overkill to me. All that is required is that all of the page contents be validated. I think we should switch to VALIDATE_ALWAYS. Basically, I'm proposing a change to this code: http://lxr.mozilla.org/mozilla/source/docshell/base/nsDocShell.cpp#5974 I think this should block freezing nsIWebNavigation.
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla1.8beta2
![]() |
||
Comment 1•18 years ago
|
||
So VALIDATE_ALWAYS will check with the server even if it's not expired from local cache yet? If so, this sounds like a perfectly reasonable change.
Assignee | ||
Comment 2•18 years ago
|
||
Yes, VALIDATE_ALWAYS unlike LOAD_BYPASS_CACHE will do a conditional query whenever possible. Otherwise, they are equivalent.
Assignee | ||
Updated•17 years ago
|
Target Milestone: mozilla1.8beta2 → mozilla1.9alpha
Assignee | ||
Comment 3•17 years ago
|
||
Here we go.
Attachment #210955 -
Flags: superreview?(bzbarsky)
Attachment #210955 -
Flags: review?(cbiesinger)
![]() |
||
Updated•17 years ago
|
Attachment #210955 -
Flags: superreview?(bzbarsky) → superreview+
Updated•17 years ago
|
Attachment #210955 -
Flags: review?(cbiesinger) → review+
Assignee | ||
Comment 4•17 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Attachment #210955 -
Flags: branch-1.8.1?(bzbarsky)
![]() |
||
Updated•17 years ago
|
Attachment #210955 -
Flags: branch-1.8.1?(bzbarsky) → branch-1.8.1+
Assignee | ||
Updated•17 years ago
|
Keywords: fixed1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•