290090 - Meta refresh should pass VALIDATE_ALWAYS instead of LOAD_BYPASS_CACHE

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Darin Fisher]

Meta refresh should pass VALIDATE_ALWAYS instead of LOAD_BYPASS_CACHE

For some reason meta refreshes of more than 15 seconds set LOAD_BYPASS_CACHE
when triggering the new page load.  That seems really overkill to me.  All that
is required is that all of the page contents be validated.  I think we should
switch to VALIDATE_ALWAYS.

Basically, I'm proposing a change to this code:
http://lxr.mozilla.org/mozilla/source/docshell/base/nsDocShell.cpp#5974

I think this should block freezing nsIWebNavigation.

Comment 1

[Boris Zbarsky [:bzbarsky]]

So VALIDATE_ALWAYS will check with the server even if it's not expired from
local cache yet?  If so, this sounds like a perfectly reasonable change.

Comment 2

[Darin Fisher]

Yes, VALIDATE_ALWAYS unlike LOAD_BYPASS_CACHE will do a conditional query
whenever possible.  Otherwise, they are equivalent.

Comment 3

[Darin Fisher]

Attachment: v1 patch

Here we go.

Comment 4

[Darin Fisher]

fixed-on-trunk