290120 - Compile source files with absolute pathnames on AIX

Status: RESOLVED FIXED

(NSS :: Build, defect, P3)

Description

[Julien Pierre]

This is a counterpart to bug 202058, which was for Windows and OS/2 .
We also need to build with absolute pathnames in order for the debugger (dbx or
idebug) to automatically locate source files on AIX.
I will use the same rules that were already implemented in the upcoming patch.
This will require using gmake 3.79 or later for the $call support .

Comment 1

[Julien Pierre]

Attachment: set NEED_ABSOLUTE_PATH on AIX

Comment 2

[Julien Pierre]

I forgot to mention that I found GNU make binaries for AIX at
http://aixpdslib.seas.ucla.edu/packages/make.html .

Comment 3

[Wan-Teh Chang]

Comment on attachment 180552 [details] [diff] [review]
set NEED_ABSOLUTE_PATH on AIX

The % is not needed for AIX.  It's not needed
for OS2, either.  (We use % in WIN% so it can
match WINNT, WIN95, and WINCE.)

The AIX case can be simply added to the existing
code, like this:

-ifeq (,$(filter-out OS2%,$(OS_TARGET))) 
+ifeq (,$(filter-out AIX OS2,$(OS_TARGET)))
 NEED_ABSOLUTE_PATH := 1
 PWD := $(shell pwd)
 endif

Is the AIX dbx different from the Solaris dbx
in this respect?  I'm wondering why one needs
absolute path but the other doesn't.

Comment 4

[Julien Pierre]

Attachment: merge AIX and OS/2 tests

Comment 5

[Wan-Teh Chang]

Comment on attachment 180612 [details] [diff] [review]
merge AIX and OS/2 tests

r=wtc.

Comment 6

[Julien Pierre]

Thanks for the review. I checked in this patch to the NSS tip.

Checking in rules.mk;
/cvsroot/mozilla/security/coreconf/rules.mk,v  <--  rules.mk
new revision: 1.60; previous revision: 1.59
done

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Julien, this patch will cause NSS builds to fail on AIX unless and until
our build tools for AIX are updated to gmake 3.79.  Has Christophe agreed 
to that?

Comment 8

[Julien Pierre]

Nelson,

Christophe is already aware of the issue. We can take this offline.

Comment 9

[Julien Pierre]

I backed out this fix temporarily since we need the build and QA to run for 3.10
tonight on AIX and Christophe didn't upgrade gmake yet.

Comment 10

[Julien Pierre]

I checked this in again, since Christophe's test of the new gmake worked.

Checking in rules.mk;
/cvsroot/mozilla/security/coreconf/rules.mk,v  <--  rules.mk
new revision: 1.62; previous revision: 1.61