290217 - Build DBM from sources in the "gmake import" build method

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[Wan-Teh Chang]

One way to build NSS is to import its dependencies
as pre-built binary components.  I call this the
"gmake import" build method.

In NSS 3.10, we no longer build DBM as a separate
component.  So NSS's "gmake import" makefile rule
needs to be updated to reflect this change.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

1. Upgrade to NSPR 4.6.  (This affects the "gmake import"
build method only.  You can continue to build NSS 3.10
against NSPR 4.4.1 or later if you do a full source
build.)

2. Do not import DBM.

3. Need to build DBM after the "gmake import" step.

Comment 2

[Robert Relyea]

Comment on attachment 180618 [details] [diff] [review]
Proposed patch

r+ if sun's ok with the change this close to 3.10 shipping.

Comment 3

[Christophe Ravel]

ok for me.
In our build, we don't use the global "nss_RelEng_bld" target.
We have: "gmake build_coreconf build_dbm all"

Comment 4

[Wan-Teh Chang]

Christophe, how do you build NSPR?  Do you use NSS's
build_nspr makefile target?

I checked in the patch on the trunk for NSS 3.10.

Enter passphrase for key '/cygdrive/c/Documents and Settings/wtc/.ssh/id_dsa':
Checking in manifest.mn;
/cvsroot/mozilla/security/nss/manifest.mn,v  <--  manifest.mn
new revision: 1.17; previous revision: 1.16
done
Checking in Makefile;
/cvsroot/mozilla/security/nss/Makefile,v  <--  Makefile
new revision: 1.34; previous revision: 1.33
done