290233 - printf format related compiler warnings

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Wan-Teh Chang]

gcc reports printf format related compiler warnings
on three files in the NSS tip.  I will attach a patch.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

1. addbuiltin.c: add the argument for the %s format specifier.

2. rsaperf.c: keybits is a long, so it needs to use the %ld format
specifier.

3. vfychain.c: add the argument for the %s format specifier.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 180632 [details] [diff] [review]
Proposed patch

I have this very identical patch in my own workarea already.  I also fixed a
number of warnings about uninitialized variables.  
Perhaps we should make this bug be the general nss 3.10 warning reduction bug.

Comment 3

[Wan-Teh Chang]

Patch checked in.

Checking in addbuiltin/addbuiltin.c;
/cvsroot/mozilla/security/nss/cmd/addbuiltin/addbuiltin.c,v  <--  addbuiltin.c
new revision: 1.13; previous revision: 1.12
done
Checking in rsaperf/rsaperf.c;
/cvsroot/mozilla/security/nss/cmd/rsaperf/rsaperf.c,v  <--  rsaperf.c
new revision: 1.15; previous revision: 1.14
done
Checking in vfychain/vfychain.c;
/cvsroot/mozilla/security/nss/cmd/vfychain/vfychain.c,v  <--  vfychain.c
new revision: 1.9; previous revision: 1.8
done