printf format related compiler warnings

RESOLVED FIXED in 3.10

Status

NSS
Libraries
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.99 KB, patch
Nelson Bolyard (seldom reads bugmail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

13 years ago
gcc reports printf format related compiler warnings
on three files in the NSS tip.  I will attach a patch.
(Assignee)

Comment 1

13 years ago
Created attachment 180632 [details] [diff] [review]
Proposed patch

1. addbuiltin.c: add the argument for the %s format specifier.

2. rsaperf.c: keybits is a long, so it needs to use the %ld format
specifier.

3. vfychain.c: add the argument for the %s format specifier.
Attachment #180632 - Flags: review?(nelson)
Comment on attachment 180632 [details] [diff] [review]
Proposed patch

I have this very identical patch in my own workarea already.  I also fixed a
number of warnings about uninitialized variables.  
Perhaps we should make this bug be the general nss 3.10 warning reduction bug.
Attachment #180632 - Flags: review?(nelson) → review+
(Assignee)

Comment 3

13 years ago
Patch checked in.

Checking in addbuiltin/addbuiltin.c;
/cvsroot/mozilla/security/nss/cmd/addbuiltin/addbuiltin.c,v  <--  addbuiltin.c
new revision: 1.13; previous revision: 1.12
done
Checking in rsaperf/rsaperf.c;
/cvsroot/mozilla/security/nss/cmd/rsaperf/rsaperf.c,v  <--  rsaperf.c
new revision: 1.15; previous revision: 1.14
done
Checking in vfychain/vfychain.c;
/cvsroot/mozilla/security/nss/cmd/vfychain/vfychain.c,v  <--  vfychain.c
new revision: 1.9; previous revision: 1.8
done
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.10
Version: 3.10 → 3.9
You need to log in before you can comment on or make changes to this bug.