nsObjectFrame's PaintSelf call does the wrong thing for paint layers

RESOLVED WORKSFORME

Status

()

defect
RESOLVED WORKSFORME
15 years ago
11 months ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({css1})

Trunk
mozilla1.8beta2
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(2 attachments, 2 obsolete attachments)

nsObjectFrame's PaintSelf call does the wrong thing for paint layers.

Testcase to come later, but patch now, so I don't lose it.
Posted patch patch (obsolete) — Splinter Review
This obviously isn't tested very well yet.

Perhaps we should put this display check inside of PaintSelf itself.  It'll
mean calling it more, but I maybe that's OK.
Status: NEW → ASSIGNED
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8beta2
Actually, we may want to drop the PaintSelf completely due to the shared style
contexts.  And I don't think this has much to do with Acid2.
No longer blocks: acid2
(In reply to comment #1)
> Perhaps we should put this display check inside of PaintSelf itself.  It'll
> mean calling it more, but I maybe that's OK.

Actually, probably not, since we need it for bug 78087.
Posted file testcase (draft)
Attachment #181393 - Attachment is obsolete: true
Hmm, this patch doesn't actually seem to help any of the testcases.
Posted patch patchSplinter Review
This is cleaned up a little, but it doesn't actually work.
Attachment #180687 - Attachment is obsolete: true
the code that's patch here will go away in bug 309521
Depends on: 309521
So is this still an issue now that bug 309521 is fixed?  That is, is there a bug when rendering a plug-in in an nsObjectFrame?
This is completely fixed in the latest trunk build of Firefox, possibly because bug 317375 have been fixed.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
The testcase seems to have regressed badly in Firefox 4.0b8. Should this bug be reopened?
Sorry, not really a regression - I was referring to red visible in the testcase, which is apparently the correct rendering - IE8 and Chrome render the same (though Chrome shows some additional rendering issues).
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.