Closed
Bug 290290
Opened 20 years ago
Closed 19 years ago
nsObjectFrame's PaintSelf call does the wrong thing for paint layers
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
WORKSFORME
mozilla1.8beta2
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Keywords: css1, Whiteboard: [patch])
Attachments
(2 files, 2 obsolete files)
8.74 KB,
text/html; charset=UTF-8
|
Details | |
2.04 KB,
patch
|
Details | Diff | Splinter Review |
nsObjectFrame's PaintSelf call does the wrong thing for paint layers.
Testcase to come later, but patch now, so I don't lose it.
Assignee | ||
Comment 1•20 years ago
|
||
This obviously isn't tested very well yet.
Perhaps we should put this display check inside of PaintSelf itself. It'll
mean calling it more, but I maybe that's OK.
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8beta2
Assignee | ||
Comment 2•20 years ago
|
||
Actually, we may want to drop the PaintSelf completely due to the shared style
contexts. And I don't think this has much to do with Acid2.
No longer blocks: acid2
Assignee | ||
Comment 3•20 years ago
|
||
(In reply to comment #1)
> Perhaps we should put this display check inside of PaintSelf itself. It'll
> mean calling it more, but I maybe that's OK.
Actually, probably not, since we need it for bug 78087.
Assignee | ||
Comment 4•20 years ago
|
||
Assignee | ||
Comment 5•20 years ago
|
||
Attachment #181393 -
Attachment is obsolete: true
Assignee | ||
Comment 6•20 years ago
|
||
Hmm, this patch doesn't actually seem to help any of the testcases.
Assignee | ||
Comment 7•20 years ago
|
||
This is cleaned up a little, but it doesn't actually work.
Attachment #180687 -
Attachment is obsolete: true
![]() |
||
Comment 9•19 years ago
|
||
So is this still an issue now that bug 309521 is fixed? That is, is there a bug when rendering a plug-in in an nsObjectFrame?
Comment 10•19 years ago
|
||
This is completely fixed in the latest trunk build of Firefox, possibly because bug 317375 have been fixed.
Assignee | ||
Updated•19 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → WORKSFORME
Comment 11•14 years ago
|
||
The testcase seems to have regressed badly in Firefox 4.0b8. Should this bug be reopened?
Assignee | ||
Comment 12•14 years ago
|
||
regressed how?
Comment 13•14 years ago
|
||
Sorry, not really a regression - I was referring to red visible in the testcase, which is apparently the correct rendering - IE8 and Chrome render the same (though Chrome shows some additional rendering issues).
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•