290375 - Switching tabs while download manager is auto-closing causes all windows to close

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[ender.mb]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050414 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050414 Camino/0.8+

This is a very strange bug. If your download manager is set to auto-close on
completing a download, and you happen to be switching tabs with the shortcut
keys (cmd+opt+left/right) at the moment a downlad finishes, all open Camino
windows will close instead of just the download manager. This does not seem to
happen when switching tabs via the mouse.

Reproducible: Always

Steps to Reproduce:
1. Make sure Preferences > Downloads > Close Downloads window is checked.
2. Begin a download.
3. When the download is about to finish, repeatedly switch tabs with
cmd+opt+right or cmd+opt+left.

Actual Results:  
All Camino windows close.

Expected Results:  
Only the download manager should close.

Comment 1

[Samuel Sidler (old account; do not CC)]

This is weird.

I'm confirming with the 04/02 build. I'm targetting for 1.0 with the camino0.9?
flag. CCing Josh as well.

Comment 2

[Mike Pinkerton (not reading bugmail)]

this sounds pretty bad, i say we keep this on the 09 radar. any ideas josh?

Comment 3

[Samuel Sidler (old account; do not CC)]

This has happened to me twice this morning. Is anyone still looking at this?

(Also, CCing Simon)

Comment 4

[Simon Fraser [no longer active]]

This happens because if you have the option key down while calling
-performClose:,  it closes all windows.

Comment 5

[Simon Fraser [no longer active]]

Fixed by calling -close on the ProgressDlgController, rather than -performClose:
on the window. Also moved the code into the ProgressDlgController.