29039 - "undo delete message" doesn't (IMAP: Mark as Deleted)

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[Akkana Peck]

I set the pref: When I delete a message, mark it as deleted.
After I delete a message in my inbox, Edit->Undo Delete Message is enabled, but
clicking it never brings the message back into my inbox, nor does hitting alt-Z
or control-Z.

I think I saw this work sometime last week, but it hasn't worked for the last
few days.  Possible regression?  But it's possible that I was using "move to
track" back when I saw it work.

Comment 1

[Phil Peterson]

Reassign to jefft

Comment 2

[jefft]

I works fine for me with today's tree on my linux box. Do you have the delete 
mode set correctly - "Delete is Move to Trash"?

Comment 3

[jefft]

Actually, Ctrl-Z is not working you can only undo delete from the Edit Menu 
Item for now.

Comment 4

[Akkana Peck]

Turns out that it doesn't work for me with "move to trash", either.  At least,
the message doesn't end up back in the inbox in any obvious place (where it was
when I deleted it, at the end of the folder, or at the beginning of the folder);
is there somewhere else I should look for it?

Comment 5

[lchiang]

bug 9704 says the message goes to the bottom of the thread pane.

Comment 6

[jefft]

After undo the message may not come back at the same position prior delete. 
There is a bug logged for that. Try with a small imap folder. Also, try removing 
the *.msf file. 

Comment 7

[Akkana Peck]

It looks like it was something about the .msf file.  Removing the .msf file is a
bad thing, as it turns out -- the result is that mozilla remembers the server
but forgets there was ever an Inbox, and I couldn't find any way to get it to
re-check the server to find the Inbox again -- but moving the whole
ImapMail/server1 directory did make it check the imap server and generate new
.msf files, and after that, Undo Delete works again.

So something (perhaps related to running in "mark messages as deleted" mode for
a while before switching back to "move to trash"?) apparently corrupted the .msf
file in a way that made undo delete stop working.

I saved the old msf files in case there's anything specific I can look for that
might be helpful.

Comment 8

[jefft]

akkana, I would like to close down this bug as work fine for me. I believe we 
have another bug logged for "mark messages as deleted" not working assigned to 
bienvenu, I believe. Reopen it if you don't agress.

Comment 9

[Akkana Peck]

Well, whatever, but aren't you worried that users changing their prefs between
the two models can get into a state where they'll never again be able to delete?
 That seems like a fairly bad bug to me, which could cause a lot of confusion.

Comment 10

[jefft]

When we done implementing all three mode of deletion we should have addressed 
the problem. I just don't want too many bugs hanging around.

Comment 11

[Akkana Peck]

Now I'm seeing this even with "move to trash" -- Edit->Undo Delete Message
doesn't do anything.

Comment 12

[selmer (gone)]

Mass moving to M16 to get these off the M15 radar.  Please let me know if this
is really an M15 stopper.

Comment 13

[selmer (gone)]

Mass moving M16 to M17 - look for nsbeta2 before anything else.

Comment 14

[scottputterman]

Moving to M18 and nominating for beta3.

Comment 15

[Akkana Peck]

In the 6/30 commercial build, Undo Del sometimes hangs the app.

Comment 16

[jefft]

Can you get a stack trace where did we hang?

Comment 17

[Akkana Peck]

Can gdb attach to a process in the case of an optimized release fullcircle
build?  Any idea how to tell which of our processes to attach to?

Comment 18

[jefft]

Cc'ing alecf. maybe alec knows how.

Comment 19

[Alec Flett]

yes, you say gdb <binary> <pid>

Comment 20

[lchiang]

Not sure where this bug stands now.

Comment 21

[laurel]

Still exists in aug01 commercial m17 build linux rh6.0. No undo for delete when
set for IMAP Mark as Deleted.  I'm comparing to 4.x where an undo will take away
the X (marked as deleted).

Comment 22

[lchiang]

+ per mail triage.  Assign to David.

Comment 23

[David :Bienvenu]

ouch, giving me an undo bug? Just shoot me now.

Comment 24

[laurel]

Same problem on aug08 commercial m18 build with NT 4.0, assume mac, too.
Changing platform to All.

Comment 25

[lchiang]

David, all you have to do is say a bug is hard to fix and the next day it'll be 
fixed :-)  

Comment 26

[David :Bienvenu]

This is simply not implemented. I'll have to see if I can adapt the imap move
copy undo action to support this.

Comment 27

[David :Bienvenu]

I have a fix for this - it may also fix problems undoing deletes and moves
involving a multiple selection of imap messages if the selection contains a
range of imap messages (i.e., the UID's of the messages are consecutive, e.g.,
1,2,3 becomes the range 1:3) - the code that noticed an undo of these kind of
operations didn't parse the range correctly. I'm not sure when this code is
invoked, but I fixed it because I needed similar code for undoing imap deletes.

Comment 28

[David :Bienvenu]

fix checked in.

Comment 29

[laurel]

Using aug25 commericial build, NT 4.0, linux rh6.0 and Mac OS 9.0:
Undo delete when Mark as Deleted is the delete mode works, but Redo doesn't work
at all.  Not sure if the Redo is related to the "stall" bug 50337...David?

Comment 30

[laurel]

Will go ahead and mark this verified since Undo does work.

Comment 31

[jefft]

David, looks like you missed the Redo() part. You probably need the following in
order to make Redo work:

Index: nsImapUndoTxn.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/imap/src/nsImapUndoTxn.cpp,v
retrieving revision 1.24
diff -u -r1.24 nsImapUndoTxn.cpp
--- nsImapUndoTxn.cpp   2000/08/16 23:35:48     1.24
+++ nsImapUndoTxn.cpp   2000/10/24 22:13:50
@@ -222,7 +222,7 @@
        nsresult rv = NS_OK;
        NS_WITH_SERVICE(nsIImapService, imapService, kCImapService, &rv);
        if (NS_FAILED(rv)) return rv;
-       if (m_isMove)
+       if (m_isMove || !m_dstFolder)
     {
         if (m_srcIsPop3)
         {