The default bug view has changed. See this FAQ.

js_AllocStack doesn't clear space it returns

RESOLVED FIXED in mozilla1.8beta2

Status

()

Core
JavaScript Engine
P1
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: brendan, Unassigned)

Tracking

({fixed-aviary1.0.4, fixed1.7.8, js1.5})

Trunk
mozilla1.8beta2
fixed-aviary1.0.4, fixed1.7.8, js1.5
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
Thus callers who alloc GC-things and push them one by one may cause a last-ditch
GC or three that scan an uninitialized or partly initialized stack segment. 
Patch so fast it will make your heads spin!

/be
(Reporter)

Comment 1

12 years ago
Created attachment 180802 [details] [diff] [review]
fix

This fixes a recent "regression" where the patch I advised jst to make to fix
an old windowwatcher GC safety bug counted on this fix, without knowing it.

/be
Attachment #180802 - Flags: review?(shaver)
Attachment #180802 - Flags: approval1.8b2+
Attachment #180802 - Flags: approval1.7.7?
Attachment #180802 - Flags: approval-aviary1.0.3?
Comment on attachment 180802 [details] [diff] [review]
fix

r=shaver
Attachment #180802 - Flags: review?(shaver) → review+
See also bug 289949 comment 26.
(Reporter)

Comment 4

12 years ago
(In reply to comment #3)
> See also bug 289949 comment 26.

which I made this bug's URL ;-).

Fixed on trunk.  Chase, if you have reason to respin any branch builds, this is
a classic one-line fix that you should take.

/be
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Priority: -- → P1
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta2
Comment on attachment 180802 [details] [diff] [review]
fix

missed 1.0.3 / 1.7.7; should try for 1.0.4 / 1.7.8
Attachment #180802 - Flags: approval1.7.8?
Attachment #180802 - Flags: approval1.7.7?
Attachment #180802 - Flags: approval1.7.7-
Attachment #180802 - Flags: approval-aviary1.0.4?
Attachment #180802 - Flags: approval-aviary1.0.3?
Attachment #180802 - Flags: approval-aviary1.0.3-

Comment 6

12 years ago
Comment on attachment 180802 [details] [diff] [review]
fix

a=chase for branches

Please land this asap.
Attachment #180802 - Flags: approval1.7.8?
Attachment #180802 - Flags: approval1.7.8+
Attachment #180802 - Flags: approval-aviary1.0.4?
Attachment #180802 - Flags: approval-aviary1.0.4+
(Reporter)

Comment 7

12 years ago
dbaron, do you want to approve for the branches?

/be
Flags: blocking-aviary1.1?
Flags: blocking-aviary1.0.4?
Keywords: fixed-aviary1.0.4, fixed1.7.8

Updated

12 years ago
Flags: blocking-aviary1.1?
Flags: blocking-aviary1.0.4?

Updated

12 years ago
Flags: testcase-
You need to log in before you can comment on or make changes to this bug.