290476 - js_AllocStack doesn't clear space it returns

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Brendan Eich [:brendan]]

Thus callers who alloc GC-things and push them one by one may cause a last-ditch
GC or three that scan an uninitialized or partly initialized stack segment. 
Patch so fast it will make your heads spin!

/be

Comment 1

[Brendan Eich [:brendan]]

Attachment: fix

This fixes a recent "regression" where the patch I advised jst to make to fix
an old windowwatcher GC safety bug counted on this fix, without knowing it.

/be

Comment 2

[Mike Shaver (:shaver emeritus)]

Comment on attachment 180802 [details] [diff] [review]
fix

r=shaver

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

See also bug 289949 comment 26.

Comment 4

[Brendan Eich [:brendan]]

(In reply to comment #3)
> See also bug 289949 comment 26.

which I made this bug's URL ;-).

Fixed on trunk.  Chase, if you have reason to respin any branch builds, this is
a classic one-line fix that you should take.

/be

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 180802 [details] [diff] [review]
fix

missed 1.0.3 / 1.7.7; should try for 1.0.4 / 1.7.8

Comment 6

[Chase Phillips]

Comment on attachment 180802 [details] [diff] [review]
fix

a=chase for branches

Please land this asap.

Comment 7

[Brendan Eich [:brendan]]

dbaron, do you want to approve for the branches?

/be