290576 - Makefile.ref fails to build on Linux/x86-64 (VA_COPY not defined)

Status: VERIFIED DUPLICATE of bug 249478

(Core :: JavaScript Engine, defect)

Description

[Mike Shaver (:shaver emeritus)]

All the standard stuff I can find points at va_copy, which I do indeed have. 
The Mozilla build doesn't define HAVE_VA_COPY at all, ever, so I am tempted to
just remove that define entirely.

Do we prefer:
-#define VARARGS_ASSIGN(foo, bar)        VA_COPY(foo,bar)
+#define VARARGS_ASSIGN(foo, bar)        va_copy(foo,bar)

or

 ifeq ($(CPU_ARCH),x86_64)
-# Use VA_COPY() standard macro on x86-64
-# FIXME: better use it everywhere
-OS_CFLAGS += -DHAVE_VA_COPY
-endif
-
-ifeq ($(CPU_ARCH),x86_64)
 # We need PIC code for shared libraries

?  I tend to the latter, to make it build the way the Mozilla build does, but
va_copy does seem to be the way of the future!

Comment 1

[Erik Fabert]

Isn't this the same issue as bug 249478?

Comment 2

[Mike Shaver (:shaver emeritus)]

Sure is.

*** This bug has been marked as a duplicate of 249478 ***