290870 - [FIXr]lack of XBL error reporting if unexpected element is found

Status: VERIFIED FIXED

(Core :: XBL, defect, P1)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

If an unexpected child element is missing from a <binding>, the entire XBL
document ends up silently being invalid somehow.  For example:

<binding>
  <property name="foo" onget="return 10" />
</binding>

will cause the document to be silently invalid (since the property needs to be
in an <implementation>), as does:

<binding>
 <implementation>
  <handlers>
   <handler .... ></>
  </handlers>
 </implementation>
</binding>

Because <handlers> should be under <binding>, not under <implementation>.

No errors seem to get reported anywhere, and there don't seem to be any logging
bits to turn on to help with this.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Possible patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Same as diff -w for ease of review

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 181086 [details] [diff] [review]
Same as diff -w for ease of review

Requesting 1.8b2 approval.  This should be quite safe and should significantly
improve our error-reporting for malformed XBL.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 181086 [details] [diff] [review]
Same as diff -w for ease of review

a=asa

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I'm now seeing correct errors sent to stderr at least (and I presume the JS
console) for the cases where I had silent failure before, so verifying this. 
Thanks!