291293 - Renaming of the folder is causing duplicate folder to be created.

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Message Display, defect)

Description

[ashish agarwal]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7.5) Gecko/20050420
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7.5) Gecko/20050420

Renaming of the folder is causing duplicate folder to be created. 

Reproducible: Always

Steps to Reproduce:
1.Open Web Browser-Mail and News Group.
2.Select any account and create a  folder ABC under Inbox.
3.Now create another folder 123 under inbox then create a folder ABC under 123.
4.Now rename the folder ABC under 123 with same name but some traling spaces.
5. drag and drop folder ABC which is under 123 to inbox.


Actual Results:  
Two folders with name ABC exists under inbox.

Expected Results:  
Should not move folder ABC which is under 123 to inbox. Duplicate
folder should not exist inside same folder.

Comment 1

[ABHIJEET BHATTACHARYA]

confirming the bug on Linux Mozilla1.7.7 and on OS/2.

Comment 2

[ABHIJEET BHATTACHARYA]

Attachment: patch to stop renaming a folder with the old name and some leading or trailing spaces.

I am stopping renaming of a folder with same name but some leading and trailing
spaces. Earlier I thought of stopping only the trailing spaces. Now think of a
same
example stated here. If I rename "ABC" which is under 123 with some leading
spaces as "	    ABC" and after that if I raname it to "ABC	       "it is
letting me to rename it, now the real problem starts . Now if I try to move
this folder to Inbox it is allowing me, I have to folder with names "ABC" now.
So I am stopping renaming of folders with some leading or trainling spaces. It
is working fine for me on OS/2.

Comment 3

[ABHIJEET BHATTACHARYA]

Attachment: right patch.

Sincere apologolies for uploadind a wrong patch, this is the right patch.

Comment 4

[ABHIJEET BHATTACHARYA]

Attachment: v2

A better patch.

Comment 5

[David :Bienvenu]

I think the approach we've been taking elsewhere is to strip off the leading and
trailing spaces in the front end js code, where we prompt the user for the new
folder name. I think I'd prefer that approach, just for consistency.

Comment 6

[ABHIJEET BHATTACHARYA]

Attachment: Patch in JavaScript

This patch is fixing the bug in Javascript frontend. As suggested by David
Bienvenu it is for consistency in code. I am not trimming the leading spaces
her e because if user wants to have some leading spaces, he can do that and it
will be visible to him .I think leading spaces should be users sole
responsibility. Your suggestions are invited on whether we should allow leading
spaces or not. But in case of the trailing spaces nobody can makeout by looking
the folder name that it has some trailing spaces included and gives the
impression that we have duplicate folder.

Comment 7

[David :Bienvenu]

Comment on attachment 190506 [details] [diff] [review]
Patch in JavaScript

seems ok to me - scott?

Comment 8

[Scott MacGregor]

Comment on attachment 190506 [details] [diff] [review]
Patch in JavaScript

this looks fine.

Comment 9

[Wayne Mery (:wsmwk)]

needs checkin help?   (patch approved)
AFAICT only slightly bitrotted - off by 3 lines

Comment 10

[Bruno 'Aqualon' Escherl]

I can't see the issue in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/2006122323 SeaMonkey/1.5a and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20061221 SeaMonkey/1.1

When I follow the steps from the bug reporter, I can't move ABC with the trailing spaces into the inbox.

Comment 11

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008060201 SeaMonkey/2.0a1pre

WFM

I cannot rename to "the same name plus some spaces" -- the rename popup doesn't go away when I click OK after typing some spaces after the existing name.

If I "cancel" the rename and try to move Inbox/123/ABC to Inbox, I get an error: "A folder with that name already exists. Please enter a different name. [  OK  ]"

If anyone sees this in a recent build, please REOPEN with useragent ("Build Identifier" from about: page) and specifics of how to reproduce.