291371 - javascript strict warnings in bookmarksMenu.js

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Jason Barnabe (np)]

Warning: anonymous function does not always return a value
Source File: chrome://browser/content/bookmarks/bookmarksMenu.js
Line: 495, Column: 12
Source Code:
      return;
      
Warning: anonymous function does not always return a value
Source File: chrome://browser/content/bookmarks/bookmarksMenu.js
Line: 501, Column: 14
Source Code:
        return;
        
Warning: anonymous function does not always return a value
Source File: chrome://browser/content/bookmarks/bookmarksMenu.js
Line: 503, Column: 14
Source Code:
        return;
        
Warning: anonymous function does not always return a value
Source File: chrome://browser/content/bookmarks/bookmarksMenu.js
Line: 509, Column: 2
Source Code:
  },
  
Warning: redeclaration of var i
Source File: chrome://browser/content/bookmarks/bookmarksMenu.js
Line: 943, Column: 13
Source Code:
    for (var i=0; i<buttons.childNodes.length; i++) {
    
Warning: assignment to undeclared variable child
Source File: chrome://browser/content/bookmarks/bookmarksMenu.js
Line: 45

Comment 1

[Jason Barnabe (np)]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 181467 [details] [diff] [review]
patch

rs=mconnor over IRC, looks fine. Request approval if you can find someone
willing to check in.

Comment 3

[Jason Barnabe (np)]

Needs checkin.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 181467 [details] [diff] [review]
patch

a=asa

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Jason, could you make another patch now that the redeclarations aren't a
problem? The plan is to have all these strict warning patches landed after the
1.1 alpha.

Comment 6

[Jason Barnabe (np)]

Attachment: [checked in] patch minus the redeclaration fix

There ya go.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Any update for the current patch? Deer Park Alpha 1 was released some days ago,
so it should be ready for checkin?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

*** Bug 296654 has been marked as a duplicate of this bug. ***

Comment 9

[Asaf Romano (gone)]

Checking in bookmarksMenu.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksMenu.js,v  <-- 
bookmarksMenu.js
new revision: 1.45; previous revision: 1.44
done

Comment 10

[:Gavin Sharp [email: [e-mail]]]

This is fixed, afaict.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

No warnings visible... => v.

Comment 12

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change