Closed Bug 291391 Opened 20 years ago Closed 20 years ago

users without the privilege to set flags should be allowed to rerequest them

Categories

(Bugzilla :: Attachments & Requests, defect)

2.19
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: myk, Assigned: myk)

Details

Attachments

(1 file, 4 obsolete files)

The group restrictions on setting flags not only prevent unprivileged users from setting flags, they also prevent such users from requesting them. But users have a legitimate need to request reconsideration of a decision recorded by the setting of a flag. In some cases, the setter has made a mistake. In others, new information has come to light or circumstances have changed. Group restrictions on setting flags should prevent unprivileged users from setting flags to + or -, but such users should still be allowed to rerequest the flags.
Attached patch patch v1: implements behavior (obsolete) — Splinter Review
Here's the patch that makes the fix. mkanat, wanna take a look at it?
Assignee: attach-and-request → myk
Status: NEW → ASSIGNED
Attachment #181481 - Flags: review?(mkanat)
Comment on attachment 181481 [details] [diff] [review] patch v1: implements behavior In a two step process, users in the request group could clear any flag. So alter the next condition to accept both X and ?.
Attachment #181481 - Flags: review?(mkanat) → review-
Attachment #181481 - Attachment is obsolete: true
Attachment #181485 - Flags: review?(LpSolit)
Attached patch patch v3: corrects code comment (obsolete) — Splinter Review
Attachment #181485 - Attachment is obsolete: true
Attachment #181486 - Flags: review?(LpSolit)
Attachment #181485 - Flags: review?(LpSolit)
Comment on attachment 181486 [details] [diff] [review] patch v3: corrects code comment The code here in Flag.pm is correct. But error messages I get for users who are neither in the grant group nor in the request group are incorrect, see user-error.html.tmpl
Attachment #181486 - Flags: review?(LpSolit) → review-
Attached patch patch v4: updates error message (obsolete) — Splinter Review
Attachment #181486 - Attachment is obsolete: true
Attachment #181488 - Flags: review?(LpSolit)
Comment on attachment 181488 [details] [diff] [review] patch v4: updates error message With this patch applied, we no longer need to pass 'old_status' to user-error.html.tmpl. *Nevertheless* I think it would not hurt to replace <code>[% name FILTER html %]</code> by <code>[% name FILTER html %][% IF status == "X" %][% old_status FILTER html %][% END %]</code> so that we also have the status of the bug we try to clear (which I personally like). This way, there is no need to remove the obsolete parameter. ;) You could fix that on checkin. r=LpSolit
Attachment #181488 - Flags: review?(LpSolit) → review+
Flags: approval?
Target Milestone: --- → Bugzilla 2.20
(In reply to comment #7) > so that we also have the status of the bug we try to clear (which I personally the status of the *flag* of course...
Error message changed upon checkin per your review comment. Thanks Frederic! Checking in Bugzilla/Flag.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v <-- Flag.pm new revision: 1.38; previous revision: 1.37 done Checking in template/en/default/global/user-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl new revision: 1.105; previous revision: 1.104 done
Flags: approval? → approval+
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: [applied to b.m.o]
Whiteboard: [applied to b.m.o]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: