291726 - FF reports extension updates available that are already installed

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050424
Firefox/1.0+

repro:
1. just wait for the update icon to appear + message updates available
2. check the versions, none of them are actually updates

I assume this is fallout from Bug 286034

Comment 1

[Peter van der Woude [:Peter6]]

I just veriefied with the owner of JSOptions 1.0
( http://www.blueprintit.co.uk/~dave/web/firefox/jsoptions/index.html )
He confirmed he hasn't made a change to the extension in the past month

Comment 2

[Robert Strong (they/them - no direct email)]

Confirming
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050424
Firefox/1.0+

Comment 3

[Robert Strong (they/them - no direct email)]

It appears that the update service is sending the string &version=app-profile to
UMO though UMO isn't providing update info with this invalid data being sent.
So, extensions that use the update info provided by UMO and extensions without
an updateURL defined in their install.rdf are not shown as needing an update.
Extensions that have a valid updateURL defined in their install.rdf are being
shown as needing an update and I suspect this is also due to the string
app-profile being used for version.

Comment 4

[Peter van der Woude [:Peter6]]

In my case all 3 extensions that pretend to require an update are non-UMO.

Comment 5

[Anbo Motohiko]

Attachment: patch

(In reply to comment #3)
> It appears that the update service is sending the string &version=app-profile
to
> UMO though UMO isn't providing update info with this invalid data being sent.


Good point.
This problem is occured by items which use custom RDF file, so UMO server is
not related.

This is caused by a simple typo. makeItem() function is refered from 3 points,
but one is wrong argument order.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

I checked this in with fixes to 291831.