291862 - Dutch trunkbuilds don't start building

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gert-Paul van der Beek]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; nl-NL; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; nl-NL; rv:1.7.7) Gecko/20050414 Firefox/1.0.3

There is an error in extra-jar.mn which causes an the Dutch trunkbuilds are not
produced. I have a patch, whitch I will include.

Reproducible: Always

Steps to Reproduce:




Normally Tim Maks handles this, but because he is away I started this bug. I
hope someone with CVS-access can check this in.

Comment 1

[Gert-Paul van der Beek]

Attachment: Patch which adds spaces before each line [checked in]

Comment 2

[Peter van der Woude [:Peter6]]

->NEW

Comment 3

[Axel Hecht]

The patch should fix the build issue, but one thing puzzled me while investigating
what really happens.
Do we really unconditionally require l10n to provide firefox help now?

Comment 4

[Anne (:annevk)]

We shipped with help in 1.0 too. What would be the problem? Also, could the
patch be checked in if it is correct so we get a Dutch testing build instead of
nothing :-)

Comment 5

[Axel Hecht]

Comment on attachment 181802 [details] [diff] [review]
Patch which adds spaces before each line [checked in]

r=me. The question about localizing help was a question in general.
And bsmedberg answered with "yes, all l10ns need to have help, even if they
just copy the en-US one over to their dir"

Comment 6

[Tim Maks van den Broek [:mad_maks]]

thanks for the review, but can someone check it in because i don't have acces 
to my computer right now.

greetings

MM

Comment 7

[Anne (:annevk)]

gandalf checked it in. The change did not appear on the tinderboxes though:
 <http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-nl>

... perhaps that takes a while.

Comment 8

[Tim Maks van den Broek [:mad_maks]]

thanks, there is always almost 3 hours between every build. so i will wait.

Comment 9

[Gert-Paul van der Beek]

The problem is still there, but yesterday I noticed another problem. The images
in http://lxr.mozilla.org/l10n/source/nl/browser/chrome/help/images/ could not
be viewed and that could be why the build still fails on extra-jar.mn, which
refers to those images. I already contacted Tim Maks about this and hopefully
the problem is solved if the images are correct in CVS. Since Tim Maks must be
at home again today, he can do this himself.

Comment 10

[Tim Maks van den Broek [:mad_maks]]

- ~22 hours ago i fixed the problem with the images, still no go
- ~19 hours ago i put the pl version of the extra-jar.mn in the nl trunk, still
no go
- ~16 hours ago i remove the line locale has help in defines.inc, still no go
- finalely i put a empty (with only the commen) extra-jar.mn and still it gives
the following error:

bad jar rule head at: locale/nl/help/images/cookie_ask.png        
(%chrome/help/images/cookie_ask.png) at ../../config/make-jars.pl line 556.

has anybody a clue what the problem can be?

MM

Comment 11

[Axel Hecht]

checked in a fixed version of revision 1.7 of extra-jar.mn. Now the end-of-file 
is ok, too.
We removed ro from the build, so hopefully it will actually pull now.

Comment 12

[Axel Hecht]

windows trunk fails on https://bugzilla.mozilla.org/show_bug.cgi?id=287262#c34
now, cvs update showed a lot of progress for quite a few locales :-)

Comment 13

[Tim Maks van den Broek [:mad_maks]]

thanks axel!