292054 - revert package names to original versions when svg is enabled

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Chase Phillips]

After enabling SVG on the Firefox trunk windows and mac build systems, the
output package names took on a new form:

  firefox-1.0+.en-US.win32-svg.installer.exe
  firefox-1.0+.en-US.mac-svg-cairo.dmg

The expected form is:

  firefox-1.0+.en-US.win32.installer.exe
  firefox-1.0+.en-US.mac.dmg

These packages need to revert back to their old filenames since we're aiming for
SVG to be the default and it's now being included on 2/3 platforms (linux coming
soon).

Comment 1

[tor]

Attachment: remove svg changes to package name

Comment 2

[Chase Phillips]

Comment on attachment 181953 [details] [diff] [review]
remove svg changes to package name

>-ifdef MOZ_SVG_RENDERER_GDIPLUG
>-MOZ_PKG_PLATFORM := $(MOZ_PKG_PLATFORM)-gdiplus
>-endif

I gather the intention on Windows systems was to add -gdiplus to the name but
it would appear 'GDIPLUG' should have been 'GDIPLUS,' hence why on Windows the
name is only -svg, not -svg-gdiplus.

r/sr=[e-mail]

Comment 3

[Chase Phillips]

Comment on attachment 181953 [details] [diff] [review]
remove svg changes to package name

Build config fix needed for alpha.

Comment 4

[Chase Phillips]

Comment on attachment 181953 [details] [diff] [review]
remove svg changes to package name

a=chase (I should've just approved this earlier)

Comment 5

[tor]

Checked in.

Comment 6

[Peter van der Woude [:Peter6]]

it's actually building both now, with and w/o svg and svg in the name
firefox-1.0+.en-US.win32-svg.zip           27-Apr-2005 23:37  6.5M
firefox-1.0+.en-US.win32.zip               27-Apr-2005 23:37  6.3M

Comment 7

[Peter van der Woude [:Peter6]]

(In reply to comment #6)
> it's actually building both now, with and w/o svg and svg in the name
> firefox-1.0+.en-US.win32-svg.zip           27-Apr-2005 23:37  6.5M
> firefox-1.0+.en-US.win32.zip               27-Apr-2005 23:37  6.3M

http://mozilla.osuosl.org/pub/mozilla.org/firefox/tinderbox-builds/beast-trunk/

only wrong on windows, mac has been changed correctly

Comment 8

[Peter van der Woude [:Peter6]]

the win32 builds with svg in the title seem to be an hourly copy of one of the
20050427 builds

Comment 9

[Tracy Walker [:tracy]]

verified with recent trunk builds