292273 - Only last comment appears if a user is logged in

Status: RESOLVED WORKSFORME

(Bugzilla :: Creating/Changing Bugs, defect, P1)

Description

[Gary Penn]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3

We are using 2.19.2 and were seeing some small performance issues so we updated
to the latest nightly 2.19.2+ (4/28/05).

Interestly the performance is resolved but we see only the most recent
"Additional Comment" item in the bug history.  There is no way for us to view
any data except the most recent comment for each bug. If we look at the same bug
in 2.19.2 the additional comments DO show up.
	 
To clarify: what is missing is the original description and all additional
comments.  What shows up instead is the Description title and then the last
posted Additional Comment.

Here's 2.19.2+:
Description:  [reply]    Opened: 2005-03-04 11:12 PT
I am decreasing the priority as this is for internal organizational
purposes only.
Bug List: (2 of 3) First Last Prev Next   Show list      Search page

Here's 2.19.2:
Description:  [reply]    Opened: 2005-03-04 11:12 PST
We have an issue that requires resolution with CQ.

------- Additional Comment #1 From Quality Assurance 2005-03-04 11:50
PST [reply] -------

Confirmed.

------- Additional Comment #2 From XXX 2005-03-07 11:06 PST [reply]
-------

I am decreasing the priority as this is for internal organizational
purposes only. 

Reproducible: Always

Steps to Reproduce:
1. Search for any bug in 2.19.2+ and look at the Additional Comments history
2.
3.

Actual Results:  
Only the last comment entered shows up.  All others are in the database and
viewable in older 2.19.2 releases but are missing here.

Expected Results:  
List out the entire history of Additional Comments and the original Description.

Comment 1

[Max Kanat-Alexander]

Definitely confirmed, I noticed the same thing on landfill. I think it's caused
by  bug 286357 -- try applying that patch and see if it fixes it.

I think the problem only occurs if you are logged in.

Comment 2

[Gary Penn]

Attachment: Patch rejection log

Comment 3

[Gary Penn]

I tried to apply the suggested patch but it hosed out.  Here's the output and
I've attached the Setting.pm.rej for review:

[root@bugzilla bugzilla]# patch -b -p0 <bug-286357-user-preference
patching file Bugzilla/User/Setting.pm
Hunk #2 FAILED at 137.
Hunk #4 FAILED at 170.
2 out of 5 hunks FAILED -- saving rejects to file Bugzilla/User/Setting.pm.rej
[root@bugzilla bugzilla]#

Comment 4

[Max Kanat-Alexander]

Right, that's a problem with that patch. You'll have to wait until we have one
that isn't bitrotten.

Comment 5

[Max Kanat-Alexander]

OK, I've confirmed that this is caused by the userprefs, and is fixed by bug 286357.

Comment 6

[Gary Penn]

I have implemented the latest patch from 286537 (a new non-bitrotten patch was
put up) and it did NOT solve the issue:

[root@bugzilla bugzilla]# patch -p0 <bug-286357-user-preference
patching file Bugzilla/User/Setting.pm
Hunk #6 succeeded at 297 (offset -12 lines).
[root@bugzilla bugzilla]# ./checksetup.pl

Still seeing the issue on all bugs.  No Additional Comment history. :(

(In reply to comment #5)
> OK, I've confirmed that this is caused by the userprefs, and is fixed by bug
286357.

Comment 7

[Gary Penn]

I do not understand why this bug was closed.  As I noted in my last comment, I
implemented the patch from 286357 and it did NOT (repeat did NOT) fix this bug.  

Comment 8

[Albert Ting]

Hi Glenn, bug #286357 was to mainly address disappearing user preferences. 
Supposedly it would have fixed your "disappearing comments" bug.  Unfortunately,
I'm not able to repeat your situation.  Max, can you?

Comment 9

[Max Kanat-Alexander]

http://landfill.bugzilla.org/bugzilla-tip/show_bug.cgi?id=2323

Works for me. It could have also been related to another fix we checked in
recently, but I'm not sure. It started working for me after I applied the patch
on the blocker.

It could have also been fixed by bug 289012.

Those are the only two checkins that could have fixed it, but it works now.

Comment 10

[Gary Penn]

So how am I to proceed?  The reality is that I have no user comments. Should I
.zip up my install and attach it?  My DB?

Comment 11

[Andrew Tolley]

(In reply to comment #10)
> So how am I to proceed?  The reality is that I have no user comments. Should I
> .zip up my install and attach it?  My DB?

We recently updated to 2.20 on our website and began experiencing this bug whereby only the last comment shows for a bug report.  After spending several hours cursing and banging my head over it ive managed to get our site working properly.

When I was ran checksetup.pl the first time through there were no errors reported, however during a subsequent re-install of bugzilla I was receiving a duplicate key error for line 3957 when updating table versions.

After spending 5 or 6 hours then trying to get the duplicate key error resolved i discovered that the "display_quips", "comment_sort_order" and "csv_colsepchar" hadn't been added to the setting or setting_value tables.  Added the entries in manually to the tables (looked at values in a working 2.20 install) and the problem with only the last comment appearing was sorted out and all comments are now appearing correctly.

Dont know if the above information is helpful to anyone still suffering from this issue after an upgrade.

Have sorted the issue with the duplicated keys in the versions table, not sure how but the table had duplicated itself in that there was two identical copies of all entries.  Now checksetup.pl runs happily and so is the bugzilla side of the website.

Andy