292348 - NewEmbededPluginStream misspelled

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

in fact, there are other misspellings of embedded too:
http://lxr.mozilla.org/seamonkey/search?string=embeded

Comment 1

[Joshua Welderson]

Attachment: Proposed Patch

I opted for the general solution and replaced all the cases linked to.

I'm a bit concerned about this one, actually, as some of the documentation
still uses 'embeded'.  Will this patch break any existing plugins, though it
compiles without issue?

Comment 2

[Brendan Eich [:brendan]]

This could break a plugin if one of the changed names is in the ABI.  Cc'ing jst
to figure out whether that's the case.

/be

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 184870 [details] [diff] [review]
Proposed Patch

jst should review, he's heir apparent for the module.  I'll sr.

/be

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 184870 [details] [diff] [review]
Proposed Patch

r+sr=jst (brendan, feel free to sr too if you really want to).

Comment 5

[timeless]

Comment on attachment 184870 [details] [diff] [review]
Proposed Patch

mozilla/layout/generic/nsSpaceManager.cpp	3.65
mozilla/modules/plugin/base/public/nsIPluginHost.idl	1.6
mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp	1.525
mozilla/modules/plugin/base/src/nsPluginHostImpl.h	1.99
mozilla/widget/src/gtkxtbin/gtk2xtbin.c 	1.11
mozilla/widget/src/gtkxtbin/gtk2xtbin.h 	1.5
mozilla/widget/src/gtkxtbin/gtkxtbin.c	1.16
mozilla/widget/src/xlibxtbin/xlibxtbin.cpp	1.5
mozilla/editor/ui/composer/content/publishprefs.js	1.16
mozilla/layout/generic/nsObjectFrame.cpp	1.506

Comment 6

[djpohly]

LXR told me that this was fixed...