292416 - Add new langGroups to Camino's font prefs

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

jshin has just checked in support for setting font prefs for a number of new
non-complex scripts (Armenian,  Bengali, Unified Canadian Syllabary, Ethiopic,
Georgian, Gujarati, Gurmukhi, Khmer, Malayalam) to the trunk in bug 237434, but
support still needs to be added to Camino because there's some binary file that
needs to be modified (bug 237434 comment 19).

Mac OS X 10.4 apparently comes with new fonts to support Tamil, which is already
on the trunk bug also missing from Camino.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Camino's font prefpane is also missing an entry for Devanagari, which, like
Tamil, was already on the trunk.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Can we get this in 0.9?  

It's not critical, because some of these langGroups aren't covered by fonts
shipped by default with Mac OS X and others won't be displayed correctly because
of the bugs in Gfx:Mac, but some langGroups do have fonts and will be displayed
properly.

Also, it seems like Camino shouldn't get further of sync with the rest of the
trunk on this, it will benefit people with fonts to handle the languages, and if
I remember correctly when Simon added zh-HK to the font prefs, it seemed like a
quick fix....

Comment 3

[Simon Fraser [no longer active]]

I think it's only worth adding languages that we have sensible default fonts
for. What is that list?

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> I think it's only worth adding languages that we have sensible default fonts
> for. What is that list?

Sorry for the delay in tracking that down; I had to do a more little research
than I wanted.

Mac OS X ships with a font for Armenian, Unified Canadian Syllabary, Devanagari,
Gujarati, and Gurmukhi, and Tamil starting with 10.4.

You can freely download fonts (either TITUS Cyberbit or the GNU Free UCS fonts)
and add Ethiopic and Georgian.  Since we already set a non-installed font for
Traditional Chinese (HK), and since the Windows defaults for the new langGroups
include a number of (the same and other) freely-downloadable fonts in their
defaults, I see no reason not to do add Ethiopic and Georgian, too.

Since bug 237434 just added default fonts for Windows, I have a patch(!) of
sorts to set the Mac equivalents; can you take that here or can you tell me
where in Core (Gfx:Mac, Layout:Fonts, ?) to open a new bug for it?

Comment 5

[Simon Fraser [no longer active]]

(In reply to comment #4)

> Since bug 237434 just added default fonts for Windows, I have a patch(!) of
> sorts to set the Mac equivalents; can you take that here or can you tell me
> where in Core (Gfx:Mac, Layout:Fonts, ?) to open a new bug for it?

Since it's Core, a new Core/Internationalization bug seems appropriate.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Given my additional discoveries (reported in bug 299222), there's no reason this
should even be a ? for 0.9.  Clearing request and targeting for 1.0 in the hopes
things will be more functional by then.

Feel free to add Canadian Aboriginal Syllabics if you're bored, though :-)

Comment 7

[Simon Fraser [no longer active]]

What can we do without a fix for 299222 and its blocking bug?

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Canadian Aboriginal Syllabics is the only free-and-clear one.  If we do that,
we'll need to set default fonts, too.

We should push this out until after you and Josh fix bug 246527, bug 205476 and
so forth (basically, the font iterator and ATSUI support for text layout)--is
that Gecko 1.9 or Gecko 2.0--whatever Camino milestone that might be.

Comment 9

[Simon Fraser [no longer active]]

Right.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Taking; this seems like it's going to be veeeeery simple after all (or, rather, now that I have two more years under my belt).

We need to think about the Text Encodings menu separately (I'm not sure what to do about it, but there are cases where people can't get pages to render correctly because they need to manually set an encoding we don't expose), since it's not this bug.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: patch

This adds all the langGroups that have been added on the trunk so far.  (There are no default fonts set for Malayalam and Khmer since Mac OS X doesn't ship with any nor are there any free/shareware AAT fonts, but XenoType Tech makes commercial fonts for these, so anyone who wants to read Malayalam or Khmer needs this UI to set them--and Firefox includes the UI, so it keeps us from getting further and further out-of-sync.)

We might want to take this opportunity to think about how we order these, since we've added 11 now.  I added them proximally similarly to Firefox (we already diverged from Firefox in the ones we had).

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(trunk-only)

Comment 13

[Chris Lawson (gone)]

Comment on attachment 285959 [details] [diff] [review]
patch

I assume this works as expected. I'm not sure what's expected, though ;)

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 285959 [details] [diff] [review]
patch

One other thought is that the "most logical" ordering alternative is alphabetical, but given the way this is set up, it means "alphabetical in English, and wacky order in every other language," so that's probably not much better than now.

I suppose we could also group broadly by geographic region....

Comment 15

[Stuart Morgan]

Comment on attachment 285959 [details] [diff] [review]
patch

rs=smorgan

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the trunk.  We can re-think the order in another bug if we so desire.