Closed Bug 29258 Opened 20 years ago Closed 19 years ago
FTP(tree) View Source brings up download dialog
From Bugzilla Helper: User-Agent: Mozilla/4.72 [en] (Win95; I) BuildID: 1999122808 If I ftp to ftp://ftp.mozilla.org and then select View Source, there is a trap in the reflow with a null layer. Reproducible: Always Steps to Reproduce: 1.Type ftp://ftp.mozilla.org in the URL bar 2.Select View source when it is finished loading Actual Results: A dialog display saying I was downloading an http-index file and then it trapped. Expected Results: On 4.X browser, view source simply shows the same content as the web browser did.
View source so reassigning to Rickg
Assignee: troy → rickg
hey Judson: this bug is not really a viewsource bug; I'm never being called by the docloader. If you want me to do viewsource on ftp dirlistings, that's fine. But you need to make sure that the mime table is set up correctly. (The same way you taught me to set it up for RTF). Let me know if I can be of any help, once you've hooked up the back end. (ps -- I'm not sure we even want to do this, but we can if you think it's necessary).
Assignee: rickg → valeski
potts. any clues on how to accomplish this nightmare? We should probably just disable view source for ftp urls.
Thie is a post to the hook from eric vaughn. A similar callstack to this trap happened when downloading a bin file on Linux. It appears that the trap at least is caused by the unknown type dialog. Whether or not view source should work is probably a separate issue. The problem is this XUL dialog is using a fieldset. Fieldsets are very problematic in XUL. There is a xul fieldset equivalent called "titledbox". This works very well in xul. Its exactly like a box but has an optional title. Here is an example: <titledbox orient="vertical"> <title><text value="the title"/></title> ... you stuff here.. </titledbox> -Eric
Does the above comment apply to this bug? I don't think fieldsets are involved in view source. I'm copying the comment to bug 29360, where I think it actually wants to be.
The original reason I opened this bug was because of the crash. I posted Erics comments because they are the source of the crash. When you select View Source on FTP, you get an unknown type file dialog which then crashes. Unknown file type dialogs in other areas of the browser are causing crashes. Since the original opening of this bug, I believe that intent has changed to disable View Source all together in FTP, since this behavior really isn't defined. I just thought y'all might be interested in knowing why the original crash actually happened.
Putting on a PDT- for beta1. Will relnote.
removing "crash" from keyword list. I can't get this to crash on nt or linux.
Status: NEW → ASSIGNED
changing summary from :"Crash when View Source after ftp to ftp://ftp.mozilla.org"
Summary: Crash when View Source after ftp to ftp://ftp.mozilla.org → FTP View Source brings up download dialog
Moving to M16.
Target Milestone: M15 → M16
scott, I think the view source content handler is asking for the content type too early. does it go through the uri loader?
Marking nsbeta2. Since view source is used frequently to analyze the page's structure, it should work consistantly.
Putting on [nsbeta2-] radar. Not critical to beta2. Will do in nsbeta3.
Side note.. Try this 1. Goto ftp://ftp.mozilla.org/ 2. View Source 3. Press "More Info" 4. The source for the plug-in finder window appears. ROTFL :)
Whiteboard: [nsbeta2-] → [nsbeta2-] [nsbeta3-]
robert-- welcome to necko!
Assignee: valeski → rjc
Status: ASSIGNED → NEW
Hi dougt, welcome to necko :)
Assignee: rjc → dougt
Scott, per email, I am assigning you my MIME related bugs.
Assignee: dougt → mscott
Still occuring on 2001031204 (win98). Updating keywords.
Making component networking: FTP.
Component: Layout → Networking: FTP
Whiteboard: [nsbeta2-] [nsbeta3-]
works in today's build.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Marking verified in the May 21 build
Status: RESOLVED → VERIFIED
+ testcase: will check for View Source to return HTML viewer's HTML w/ XUL tree view.
Summary: FTP View Source brings up download dialog → FTP(tree) View Source brings up download dialog
You need to log in before you can comment on or make changes to this bug.