29258 - FTP(tree) View Source brings up download dialog

Status: VERIFIED FIXED

(Core Graveyard :: Networking: FTP, defect, P3)

Description

[Mike Kaply [:mkaply]]

From Bugzilla Helper:
User-Agent: Mozilla/4.72 [en] (Win95; I)
BuildID:    1999122808

If I ftp to ftp://ftp.mozilla.org and then select View Source, there is a trap 
in the reflow with a null layer.

Reproducible: Always
Steps to Reproduce:
1.Type ftp://ftp.mozilla.org in the URL bar
2.Select View source when it is finished loading


Actual Results:  A dialog display saying I was downloading an http-index file 
and then it trapped.

Expected Results:  On 4.X browser, view source simply shows the same content as 
the web browser did.

Comment 1

[troy]

View source so reassigning to Rickg

Comment 2

[rickg]

hey Judson: this bug is not really a viewsource bug; I'm never being called by 
the docloader. If you want me to do viewsource on ftp dirlistings, that's fine. 
But you need to make sure that the mime table is set up correctly. (The same way  
you taught me to set it up for RTF). 

Let me know if I can be of any help, once you've hooked up the back end. 
(ps -- I'm not sure we even want to do this, but we can if you think it's 
necessary).

Comment 3

[Judson Valeski]

potts. any clues on how to accomplish this nightmare? We should probably just
disable view source for ftp urls.

Comment 4

[Mike Kaply [:mkaply]]

Thie is a post to the hook from eric vaughn.

A similar callstack to this trap happened when downloading a bin file on Linux.

It appears that the trap at least is caused by the unknown type dialog. Whether 
or not view source should work is probably a separate issue.

The problem is this XUL dialog is using a fieldset. Fieldsets are very
problematic in XUL. There is a xul fieldset equivalent called
"titledbox". This works very well in xul. Its exactly like a box but has
an optional title. Here is an example:

<titledbox orient="vertical">
    <title><text value="the title"/></title>

    ... you stuff here..

</titledbox>

-Eric

Comment 5

[Dan M]

Does the above comment apply to this bug? I don't think fieldsets are involved in 
view source. I'm copying the comment to bug 29360, where I think it actually 
wants to be.

Comment 6

[Mike Kaply [:mkaply]]

The original reason I opened this bug was because of the crash. I posted Erics 
comments because they are the source of the crash. When you select View Source 
on FTP, you get an unknown type file dialog which then crashes. Unknown file 
type dialogs in other areas of the browser are causing crashes.

Since the original opening of this bug, I believe that intent has changed to 
disable View Source all together in FTP, since this behavior really isn't 
defined.

I just thought y'all might be interested in knowing why the original crash 
actually happened.

Comment 7

[leger]

Putting on a PDT- for beta1.  Will relnote.

Comment 8

[Judson Valeski]

removing "crash" from keyword list. I can't get this to crash on nt or linux.

Comment 9

[Judson Valeski]

changing summary from :"Crash when View Source after ftp to
ftp://ftp.mozilla.org"

Comment 10

[Warren Harris]

Moving to M16.

Comment 11

[Judson Valeski]

scott, I think the view source content handler is asking for the content type
too early. does it go through the uri loader?

Comment 12

[Chris Petersen]

Marking nsbeta2. Since view source is used frequently to analyze the page's 
structure, it should work consistantly.

Comment 13

[leger]

Putting on [nsbeta2-] radar. Not critical to beta2.  Will do in nsbeta3.

Comment 14

[jlarsen]

Side note..  Try this
1. Goto ftp://ftp.mozilla.org/
2. View Source
3. Press "More Info"
4. The source for the plug-in finder window appears.  ROTFL :)

Comment 15

[Judson Valeski]

relnote.

Comment 16

[Gagan]

robert-- welcome to necko!

Comment 17

[Gagan]

Hi dougt, welcome to necko :)

Comment 18

[Doug Turner (:dougt)]

Scott, per email, I am assigning you my MIME related bugs.  

Comment 19

[Tony Jordan]

Still occuring on 2001031204 (win98).

Updating keywords.

Comment 20

[karnaze (gone)]

Making component networking: FTP.

Comment 21

[matt]

works in today's build.

Comment 22

[Chris Petersen]

Marking verified in the May 21 build

Comment 23

[benc]

+ testcase: will check for View Source to return HTML viewer's HTML w/ XUL tree 
view.