292969 - Thawing presshell could synchronously reenter nsDocShell::RestorePresentation

Status: RESOLVED WONTFIX

(Core :: DOM: Navigation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Thawing will reframe plugins, which can fire broken-plugin events, which can
trigger code that changes the URI in the docshell or triggers history traversals.

That would synchronously reenter nsDocShell::RestorePresentation and probably
make the docshell somewhat confused.

Comment 1

[Brian Ryner (not reading)]

I'm not convinced that it's actually a problem since Thaw() is the absolute last
thing that we do.  After calling Thaw(), the docshell totally unwinds from
RestorePresentation/InternalLoad/LoadURI.  So, we wouldn't get into a situation
where we make assumptions about the current URI or content viewer after
RestorePresentation finishes.

It's a bit fragile, I think we can live with it though for FF 1.5.  I'll write
up a testcase for completeness.

Comment 2

[Brian Ryner (not reading)]

Attachment: testcase

Note that the testcase does not function, i.e. you are not ever redirected to
www.mozilla.org.  I think the reason is the check for an actual PluginInstance
that was done for bug 299153.

Comment 3

[Brian Ryner (not reading)]

pushing out since I can't find anything that actually breaks

Comment 4

[Andrei Purice]

Tested this on Chrome and Firefox and it has the same behaviour using the provided test case. I get redirected to google.com instead of mozilla.com as Bryan said it should.
Boris is this still reproducible for you or should we close it?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

nsDocShell::RestorePresentation is going away anyway.