292987 - Mozilla build failure on Solaris due to checkin for 274784

Status: RESOLVED WORKSFORME

(Core :: Security: PSM, defect)

Description

[Mitch]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1)
Build Identifier: 

Build failure:

/share/lang/solaris/7.0/SUNWspro/bin/CC -I/home/mitch/bld/support/include -o
nsSecureBrowserUIImpl.o -c  -DMOZILLA_INTERNAL_API -DOSTYPE=\"SunOS5\"
-DOSARCH=\"SunOS\" -DBUILD_ID=2005050507  -I../../../../dist/include/nspr
-I../../../../dist/include/xpcom -I../../../../dist/include/string
-I../../../../dist/include/necko -I../../../../dist/include/uriloader
-I../../../../dist/include/dom -I../../../../dist/include/intl
-I../../../../dist/include/docshell -I../../../../dist/include/widget
-I../../../../dist/include/layout -I../../../../dist/include/content
-I../../../../dist/include/pref -I../../../../dist/include/pipboot
-I../../../../dist/include -I../../../../dist/include/nspr   
-I../../../../dist/public/nss     -KPIC   -I/home/mitch/bld/support/include
-xbuiltin=%all -features=tmplife -mt  -DNDEBUG -DTRIMMED -O  
-DMOZILLA_VERSION=\"1.8b2\" -DMOZILLA_VERSION_MAJOR=1 -DMOZILLA_VERSION_MINOR=8
-DSOLARIS=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DD_INO=d_ino -DSTDC_HEADERS=1
-DHAVE_ST_BLKSIZE=1 -DHAVE_SIGINFO_T=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1
-DHAVE_INT64_T=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1
-DHAVE_DIRENT_H=1 -DHAVE_SYS_BYTEORDER_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1
-DHAVE_NL_TYPES_H=1 -DHAVE_MALLOC_H=1 -DHAVE_X11_XKBLIB_H=1
-DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1
-DHAVE_LIBSOCKET=1 -DFUNCPROTO=15 -DHAVE_XSHM=1 -D_REENTRANT=1 -DHAVE_RANDOM=1
-DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1 -DHAVE_SNPRINTF=1
-DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_STAT64=1 -DHAVE_LSTAT64=1
-DHAVE_FLOCKFILE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STRTOK_R=1
-DHAVE_LANGINFO_CODESET=1 -DVA_COPY=va_copy -DHAVE_VA_COPY=1
-DHAVE_I18N_LC_MESSAGES=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk\" -DMOZ_WIDGET_GTK=1
-DMOZ_ENABLE_XREMOTE=1 -DMOZ_X11=1 -DMOZ_SUITE=1 -DMOZ_BUILD_APP=suite
-DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DMOZ_ENABLE_COREXFONTS=1
-DMOZ_EXTRA_X11CONVERTERS=1 -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1
-DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DMOZ_XTF=1
-DHAVE_GSSAPI_GSSAPI_H=1 -DHAVE_GSS_C_NT_HOSTBASED_SERVICE=1 -DMOZ_MATHML=1
-DMOZ_STORAGE=1 -DMOZ_LOGGING=1 -DMOZ_USER_DIR=\".mozilla\" -DMOZ_XUL=1
-DMOZ_PROFILESHARING=1 -DMOZ_PROFILELOCKING=1 -DMOZ_DLL_SUFFIX=\".so\"
-DXP_UNIX=1 -DUNIX_ASYNC_DNS=1 -DJS_THREADSAFE=1 -DNS_PRINT_PREVIEW=1
-DNS_PRINTING=1 -DMOZILLA_LOCALE_VERSION=\"1.8b2\"
-DMOZILLA_REGION_VERSION=\"1.8b2\" -DMOZILLA_SKIN_VERSION=\"1.5\" 
-D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT nsSecureBrowserUIImpl.cpp
"nsSecureBrowserUIImpl.cpp", line 134: Warning (Anachronism): Using const
void*(*)(PLDHashTable*,PLDHashEntryHdr*) to initialize extern "C" const
void*(*)(PLDHashTable*,PLDHashEntryHdr*).
"nsSecureBrowserUIImpl.cpp", line 136: Warning (Anachronism): Using
int(*)(PLDHashTable*,const PLDHashEntryHdr*,const void*) to initialize extern
"C" int(*)(PLDHashTable*,const PLDHashEntryHdr*,const void*).
"nsSecureBrowserUIImpl.cpp", line 140: Warning (Anachronism): Using
int(*)(PLDHashTable*,PLDHashEntryHdr*,const void*) to initialize extern "C"
int(*)(PLDHashTable*,PLDHashEntryHdr*,const void*).
"nsSecureBrowserUIImpl.cpp", line 1511: Error:
nsSecureBrowserUIImpl::lockIconState is not accessible from
nsSecureBrowserUIImpl::State.
"nsSecureBrowserUIImpl.cpp", line 1513: Error:
nsSecureBrowserUIImpl::lockIconState is not accessible from
nsSecureBrowserUIImpl::State.
"nsSecureBrowserUIImpl.cpp", line 1517: Error:
nsSecureBrowserUIImpl::lockIconState is not accessible from
nsSecureBrowserUIImpl::State.
"nsSecureBrowserUIImpl.cpp", line 1523: Error:
nsSecureBrowserUIImpl::lockIconState is not accessible from
nsSecureBrowserUIImpl::State.
4 Error(s) and 3 Warning(s) detected.
gmake[5]: *** [nsSecureBrowserUIImpl.o] Error 4
gmake[5]: Leaving directory
`/share/chroot/on28/share/bld/u/scratch/mitch/mozilla/mozilla/security/manager/boot/src'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory
`/share/chroot/on28/share/bld/u/scratch/mitch/mozilla/mozilla/security/manager/boot'
gmake[3]: *** [libs] Error 2
gmake[3]: Leaving directory
`/share/chroot/on28/share/bld/u/scratch/mitch/mozilla/mozilla/security/manager'
gmake[2]: *** [tier_50] Error 2
gmake[2]: Leaving directory
`/share/chroot/on28/share/bld/u/scratch/mitch/mozilla/mozilla'
gmake[1]: *** [default] Error 2
gmake[1]: Leaving directory
`/share/chroot/on28/share/bld/u/scratch/mitch/mozilla/mozilla'
gmake: *** [build] Error 2


Reproducible: Always

Steps to Reproduce:

Actual Results:  
Build failure

Comment 1

[Mitch]

This is most probbaly due to bryner's checking yesterday to
nsSecureBrowserUIImpl.cpp for bug 274784. Adding Bryner to cc

Comment 2

[Andrew Schultz]

tinderboxen seem to be fine.  are you using Sun or PC hardware?

Comment 3

[Mitch]

Sun Sparc

Comment 4

[km]

I see the same thing on Solaris (9 and 10) Sparc with the Studio 9 compilers.

Any work around?

Comment 5

[Kyle Yuan]

This is a known issue for the Sun ONE Studio compilers and Studio 10 changed the
rule. See http://docs.sun.com/source/819-0488/1.html#57298 for detail.

Comment 6

[Mitch]

Kyle i tried your suggestion, it doesn't like the flags:

/share/lang/solaris/9.0/SUNWspro/bin/CC -I/home/mitch/bld/support/include 
-features=no%nestedaccess -o conftest -I/home/mitch/bld/support/include  
-L/home/mitch/bld/support/lib test.c
CC: illegal option usage -features=no%nestedaccess


/share/lang/solaris/9.0/SUNWspro/bin/CC -V
CC: Sun C++ 5.6 2004/07/15

Comment 7

[Kyle Yuan]

Sorry, I did not make it clear. 

In Sun ONE Stusio 9 and earlier versions, c++ compiler does *NOT* allow nested
classes to access private members of the enclosing class. That is the cause of
this bug. Sun ONE Studio 10 changed this rule to *allow* nested classes to
access private members of the enclosing class.  -features=no%nestedaccess is
only introduced by studio 10 to simulate studio 9's behavior.  So
* only Studio 10 can successfully build the source code without any code change
and apply any additional compiling switches;
* no way for Studio 9 or earlier version to work around this, you have to change
the mozilla source code.

Comment 8

[Andreas Lange]

*** Bug 293648 has been marked as a duplicate of this bug. ***

Comment 9

[km]

Is there going to be any movement on this? Upgrading to Studio 10 is not
feasible for many, and this is a real stopper for doing recent Solaris builds.

Comment 10

[Kyle Yuan]

The movement is very simple - to make the |lockIconState| to be a public member
for the Sun Studio compiler. You can go ahead to submit a patch and ask review
from bryner.

Comment 11

[Andreas Lange]

Attachment: Trivial fix

As Kyle said, move |lockIconState| enum declaration from protected to public.
Fixes Sun studio breakage.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 183900 [details] [diff] [review]
Trivial fix

There's a general solution for this type of problem described in
http://www.mozilla.org/hacking/portable-cpp.html#inner_classes	Please use that
rather than changing access.  In particular, right below "class State;" add a
line "friend class State;".

Comment 13

[Andreas Lange]

Uhm. It looks like the patch in bug 292971 which landed on 2005-06-15 16:52
removed the problematic code from bug 274784. Haven't had time to try a
recompile yet, but in that case this isn't an issue anymore.

Comment 14

[Andreas Lange]

Recompiled w/o any patch, WFM now.