Closed
Bug 293162
Opened 19 years ago
Closed 19 years ago
InnerHTML on textarea shouldn't just treat the HTML as text
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: mrbkap)
References
Details
Attachments
(1 file)
2.46 KB,
patch
|
peterv
:
review+
jst
:
superreview+
shaver
:
approval1.8b3+
|
Details | Diff | Splinter Review |
We should be using the parser, but the skipped content mess prevents us. Once bug 272702 is fixed, we can probably remove this method from this class altogether and just use the generic SetInnerHTML.
Reporter | ||
Comment 1•19 years ago
|
||
Not quite doable yet because the <body> hack (which may be removable once bug 289537 is fixed) gives a random <body> string in the textarea. That, plus tokenizer weirdness leading to nested textarea tags in the resulting DOM...
Depends on: 289537
Assignee | ||
Updated•19 years ago
|
Assignee | ||
Comment 2•19 years ago
|
||
This isn't quite ready for review/check in, but it's getting close so I wanted to attach the patch that fixes this bug for good.
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Assignee | ||
Updated•19 years ago
|
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 185699 [details] [diff] [review] patch v1 All of the dependencies are fixed. I've tested, and this doesn't regress anything too noticeably (i.e., I didn't see anything bad happen). It'd be nice to get this in pretty soon.
Attachment #185699 -
Flags: superreview?(jst)
Attachment #185699 -
Flags: review?(bugmail)
Assignee | ||
Updated•19 years ago
|
Attachment #185699 -
Flags: review?(bugmail) → review?(peterv)
Updated•19 years ago
|
Attachment #185699 -
Flags: review?(peterv) → review+
Comment 4•19 years ago
|
||
Comment on attachment 185699 [details] [diff] [review] patch v1 sr=jst
Attachment #185699 -
Flags: superreview?(jst) → superreview+
Assignee | ||
Comment 5•19 years ago
|
||
Comment on attachment 185699 [details] [diff] [review] patch v1 This finally fixes textarea's innerHTML to not be broken. It should go in now so as to get the maximum amount of testing possible.
Attachment #185699 -
Flags: approval1.8b3?
Comment on attachment 185699 [details] [diff] [review] patch v1 a=shaver
Attachment #185699 -
Flags: approval1.8b3? → approval1.8b3+
Assignee | ||
Comment 7•19 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Component: DOM: Mozilla Extensions → DOM
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•