293201 - Need to filter better in the agenda view

Status: RESOLVED INVALID

(Calendar :: Lightning Only, defect)

Description

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

If nothing else, selecting all calendars, current view, or single calendars.

Comment 1

[Joey Minta]

Attachment: part 1- turn on tasks option

Right now the menu-option to filter All/Events/Tasks doesn't do anything.  This
patch makes it active.	Doing so requires adding getOccurrencesBetween to
calTodo.js.  I basically did a copy+paste of the calEvent version, with a few
changes to handle the fact that tasks don't always have due/entryDates.

I also modified the agendaTree to look for a task's dueDate instead of
entryDate, because the lightning task dialog doesn't offer an entryDate option.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 196939 [details] [diff] [review]
part 1- turn on tasks option

Looks good; just a few nits.  Thanks for the patch.

> agendaTreeView.findPeriodForItem =
> function findPeriodForItem(item)
> {
>-    var start = item.startDate || item.entryDate;
>+    var start = item.startDate || item.dueDate;
>+    if(!start) 
>+        return null;

Add a space before the parens, if you would.

>+agendaTreeView.updateFilter =
>+function updateAgendaFilter(menulist) {
>+    if (menulist.selectedItem.value)
>+        this.filterType = menulist.selectedItem.value
>+    else
>+        this.filterType = 'all';

Is it really possible for this function ever to be called with
menulist.selectedItem.value unset?  If so, please add braces around both
clauses; if not, it should be possible to shorten this function by 60%.  :-)

>+    this.refreshCalendarQuery();
>+};

Please add an explicit return here.

r=dmose with this stuff addressed

Comment 3

[Joey Minta]

Comment on attachment 196939 [details] [diff] [review]
part 1- turn on tasks option

patch checked in.  leaving bug open to add calendar filtering as well.

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Unfortunately, I do not have cycles to work on Calendar stuff these days (just as it's getting to the good part!), so I am a bad owner for these bugs.  To delete the tragically-large chunk of bugspam, search for gregorianabdication.

Comment 5

[Omar Bajraszewski]

Now there are two view filters in Today Pane:
1)Tasks&Events<->Tasks<->Events
2)All<->Events<->Tasks (This is only for agenda)

When you select Events in 1st filter and Tasks in 2nd filter you can see tasks. It  is really strange and confusing. Maybe the first filter should be renamed

Comment 6

[Stefan Sitter [:ssitter]]

Is this bug still required? In current Lightning 0.9pre builds only events are displayed in the agenda section of the today pane. Selecting the calendars that are displayed is already being worked on in Bug 412800.

Comment 7

[Martin Schröder [:mschroeder]]

(In reply to comment #6)
> Is this bug still required? In current Lightning 0.9pre builds only events are
> displayed in the agenda section of the today pane. Selecting the calendars that
> are displayed is already being worked on in Bug 412800.

Stefan, I agree. What is the correct resolution?

Comment 8

[Martin Schröder [:mschroeder]]

Resolving as INVALID per comment#6 and comment#7.