293208 - Display the user's current IP address on the login page

Status: RESOLVED WONTFIX

(Bugzilla :: User Interface, enhancement)

Description

[Jason Pyeron]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; .NET CLR 1.0.3705; .NET CLR 1.1.4322)
Build Identifier: 

add ip address to login page

Reproducible: Always

Steps to Reproduce:

Comment 1

[Jason Pyeron]

Attachment: adds user's ip

Comment 2

[Jason Pyeron]

sorry but the patch does not have the correct header, and my internet is acting 
screwy.

it is for template/en/default/account/auth/login.html.tmpl

Comment 3

[Christian Reis]

Comment on attachment 182828 [details] [diff] [review]
adds user's ip

I would suggest placing the USE line in the beginning of the file.

IIRC we're not restricting to a specific IP, but to a variable network slice in
which that IP is inserted, right?

Comment 4

[Jacob Steenhagen]

(In reply to comment #3)
> IIRC we're not restricting to a specific IP, but to a variable network slice in
> which that IP is inserted, right?

Without looking at the code, I believe the answer to that question is: it
depends. IIRC, there's now a Param() that allows the admin to specify the
network mask. Also IIRC, the default is still /32 (or this IP).

Comment 5

[Vlad Dascalu]

Comment on attachment 182828 [details] [diff] [review]
adds user's ip

The current patch makes Bugzilla to lie when the network mask in the params is
different from 32.

Comment 6

[victory <[e-mail]>]

Attachment: patch for tip

updated.
take #3
i don't understand what #5 means :-(

Comment 7

[Olav Vitters]

Comment on attachment 236511 [details] [diff] [review]
patch for tip

t/008filter..........NOK 232#   Failed test '(en/default) template/en/default/account/auth/login-small.html.tmpl has unfiltered directives:
#   70: Bugzilla.cgi.remote_host() 
# --ERROR'
#   in t/008filter.t at line 131.

#   Failed test '(en/default) template/en/default/account/auth/login.html.tmpl has unfiltered directives:
#   74: Bugzilla.cgi.remote_host() 
# --ERROR'
#   in t/008filter.t at line 131.
t/008filter..........NOK 233# Looks like you failed 2 tests of 272.

AKA: add FILTER html

This is required as remote_host() could possibly be a hostname with '<', etc.

Comment 8

[Frédéric Buclin]

There has been no rationale on why displaying the IP address would be useful to the user. Marking as wontfix.

Comment 9

[Jason Pyeron]

The rationale was some users were experiencing issues with their ISP assigning IP addresses in conjunction to the “restrict to this IP” check box.