Closed Bug 293249 Opened 15 years ago Closed 13 years ago

Don't pretend to support canvas when cairo isn't built

Categories

(Core :: Canvas: 2D, defect)

defect
Not set

Tracking

()

RESOLVED WONTFIX

People

(Reporter: sicking, Assigned: vlad)

Details

We should not pretend to support canvas by instantiating nsHTMLCanvasElements
when cairo isn't built. Then we should use fallback and render the contents of
the canvas element instead.

We should just instantiate nsHTMLDivElement and not even build
nsHTMLCanvasElement.cpp or nsHTMLCanvasFrame.cpp. We could even kill the various
interface files maybe.

IMHO the parser changes could be left as is always though to avoid cluttering up
the parser code. Just #define NS_NewHTMLCanvasElement to NS_NewHTMLDivElement
Flags: blocking-aviary1.1?
I had code to do this, but we explicitly killed it based on a discussion with
breadan and others, since cairo won't be an optional dependancy for very long.
Are we including cairo on all platforms, including things like minimo and beos?
Flags: blocking1.8b4?
Flags: blocking-aviary1.1?
No reason for this to block 1.8b4, IMO.

I don't know what the Minimo or BeOS plan is; but <canvas> and cairo are a core
part of Gecko..
Flags: blocking1.8b4? → blocking1.8b4-
we're requiring cairo everywhere now.  builds without cairo are now unsupported.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.