29329 - DOM Range crash - set(Start|End)(Before|After) given node with null parent

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

DESCRIPTION:  I crash in Range::SetStartBefore() if I give it a node whose
parentNode is null.  I think the fix to this bug may be to change these four
functions to get the parent before calling IndexOf(), and throw an exception if
the parent is null.  But you may want to have a null check in IndexOf() also.

STEPS TO REPRODUCE:
 * load attached test case

ACTUAL RESULTS:
 * crash in nsRange::IndexOf(), when dereferencing the pointer to the parent
node.

EXPECTED RESULTS:
 * no crash

DOES NOT WORK CORRECTLY ON:
 * Linux, mozilla, 2000-02-24-15-M14

ADDITIONAL INFORMATION:
I posted a message to www-dom about which exception should be thrown (and
whether it should be thrown):
http://lists.w3.org/Archives/Public/www-dom/2000JanMar/0107.html

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: testcase causing crash (for only one of the 4 functions)

Comment 2

[vidur (gone)]

Passing along to Joe Francis - the owner of the Range implementation.

Comment 3

[Kathleen :Brade]

Vidur--I assume that this isn't something we would want to fix immediately; 
please let me know if you feel otherwise.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The DOM2 spec has been slightly revised to note exceptions based on refNode's
ancestors:
http://www.w3.org/TR/DOM-Level-2/range.html#Level-2-Range-idl

Comment 5

[Joe Francis]

accepting....

Comment 6

[rubydoo123]

moving this to M16

Comment 7

[rubydoo123]

bumping up priority on this one

Comment 8

[leger]

Adding crash keyword

Comment 9

[rubydoo123]

m17

Comment 10

[Joe Francis]

i have fix in hand

Comment 11

[Phil Peterson]

[nsbeta2+] Would like to have this fix. Not sure how easily a user encounters
the crash, but if the bug stays open a long time, we will ask about that as a
cut criteria.

Comment 12

[rubydoo123]

m16

Comment 13

[Joe Francis]

fixed

Comment 14

[leger]

Updating QA Contact.

Comment 15

[Prashant Desale]

Verified with 2000-06-01-08.