293558 - CairoGradient can use an uninitialized |gradient|

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The build warning is:

../../../../../../mozilla/layout/svg/renderer/src/cairo/nsSVGCairoGradient.cpp:142:
warning: `
   cairo_pattern_t*gradient' might be used uninitialized in this function

For once, gdb is right.  The gradient frame will return
nsISVGGradient::SVG_UNKNOWN_GRADIENT in some cases, and then we'll never init
|gradient| in this method.

To test, try an XBL binding that extends svg:linearGradient...  That will get a
gradient frame, I believe.  In any case, we should just bail out on unknown
gradient type.

Comment 1

[Scooter Morris]

Attachment: Just return if we're not a linear or radial gradient.

Comment 2

[Scooter Morris]

Attachment: Just return if we're not a linear or radial gradient (without extra assignment)

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 183189 [details] [diff] [review]
Just return if we're not a linear or radial gradient (without extra assignment)

a=shaver

Comment 4

[tor]

Checked in for scooter.