Temporary network's secure/non-secure properties don't get updated when trying to reconnect

RESOLVED FIXED

Status

--
minor
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-patch][cz-0.9.68.5])

Attachments

(1 attachment)

2.20 KB, patch
bugzilla-mozilla-20000923
: review+
Details | Diff | Splinter Review
(Assignee)

Description

14 years ago
Trying to connect to a server using a secure connection fails if you connected
to the same server before using a normal connection.

Steps to reproduce:
1. /attach irc.mozilla.org:6697
2. Watch it fail, since you're trying to attach normally using a port which is
only available for SSL connections (note that not all secure servers will behave
this way).
3. /attach ircs://irc.mozilla.org:6697
4. Watch it fail, saying this network does not have secure servers.

To fix this, cmdServer and cmdSSLServer need to cope with temporary networks
differently. Patch coming up.

As a workaround, you can close ChatZilla and reopen it, or manually set
e.network.primServ.isSecure to true.
(Assignee)

Comment 1

14 years ago
Created attachment 183193 [details] [diff] [review]
Patch

Patches cmdServer and cmdSSLServer to set the primServ's isSecure bit correctly
if the server is temporary.
Attachment #183193 - Flags: review?(silver)

Updated

14 years ago
Whiteboard: cz-patch

Comment 2

14 years ago
Comment on attachment 183193 [details] [diff] [review]
Patch

r=silver
Attachment #183193 - Flags: review?(silver) → review+
(Assignee)

Comment 3

14 years ago
Comment on attachment 183193 [details] [diff] [review]
Patch

Requesting approval for harmless CZ patches
Attachment #183193 - Flags: approval1.8b3?

Updated

14 years ago
Whiteboard: cz-patch → [cz-patch][cz-0.9.68.5]
Comment on attachment 183193 [details] [diff] [review]
Patch

a=shaver
Attachment #183193 - Flags: approval1.8b3? → approval1.8b3+

Comment 5

14 years ago
Checked in -> FIXED.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.