293887 - Deleted records in the Password Manager reappear when the PM is re-opened

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Alexander Rabtchevich]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050510
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050510

Password manager has got a lot of records with mail passwords. They are removed,
but restarting of Mozilla causes them to appear again.

Reproducible: Always

Comment 1

[Philip Chee]

Additional information:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050824
SeaMonkey/1.0a Mnenhy/0.7.2.0

Error: [JavaScript Error: "uncaught exception: [Exception... "Component returned
failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIPasswordManager.removeUser]" 
nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://communicator/content/wallet/SignonViewer.js :: FinalizeSignonDeletions
:: line 393"  data: no]"]

Comment 2

[Philip Chee]

Still happening in: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060817

Possible regression from Bug 78262

Comment 3

[Bruno 'Aqualon' Escherl]

WFM with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060729 SeaMonkey/1.0.4 Mnenhy/0.7.4.0, all mailbox password entrys I removed were really removed and SeaMonkey asked for the passwords after a restart.

Comment 4

[Philip Chee]

It looks like it only fails if there are multiple identical duplicate entries. The gm-notifier creates multiple identical entries with a site of chrome://gm-notifier/. I can successfully delete an entry if it is unique.

http://lxr.mozilla.org/seamonkey/source/extensions/wallet/src/singsign.cpp#623

It looks like Wallet_Decrypt(crypt, decrypted) is returning NS_FAILED here.

cc dveditz

Comment 5

[Philip Chee]

Fixed by Bug 390025 (Move to LoginManager and remove wallet from SeaMonkey)