Closed
Bug 294075
Opened 20 years ago
Closed 18 years ago
password manager should not crash if it fails to get the profile directory [@ nsPasswordManager::Init]
Categories
(Toolkit :: Password Manager, defect)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: mwu)
References
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
694 bytes,
patch
|
benjamin
:
review+
asa
:
approval-aviary1.1a1+
|
Details | Diff | Splinter Review |
This seems to come up in some embedding cases. Currently, if we fail to get
NS_APP_USER_PROFILE_50_DIR, the password manager will crash.
Reporter | ||
Comment 1•20 years ago
|
||
bsmedberg, does this look ok? Is there some other sort of fallback we should
have, or a better way of getting the profile directory?
Attachment #183537 -
Flags: review?(benjamin)
Comment 2•20 years ago
|
||
Comment on attachment 183537 [details] [diff] [review]
null-check mSignonFile
No, this is perfect.
Attachment #183537 -
Flags: review?(benjamin) → review+
Reporter | ||
Comment 3•20 years ago
|
||
Comment on attachment 183537 [details] [diff] [review]
null-check mSignonFile
requesting approval, trivial null check
Attachment #183537 -
Flags: approval-aviary1.1a1?
Comment 4•20 years ago
|
||
Comment on attachment 183537 [details] [diff] [review]
null-check mSignonFile
a=asa
Attachment #183537 -
Flags: approval-aviary1.1a1? → approval-aviary1.1a1+
Comment 7•19 years ago
|
||
*** Bug 306424 has been marked as a duplicate of this bug. ***
Updated•19 years ago
|
Whiteboard: [checkin needed]
Updated•19 years ago
|
Severity: normal → critical
Summary: password manager should not crash if it fails to get the profile directory → password manager should not crash if it fails to get the profile directory [@ nsPasswordManager::Init]
Updated•19 years ago
|
Flags: blocking1.9a1+
Comment 8•19 years ago
|
||
Brian: are you going to land this patch?
Comment 9•18 years ago
|
||
*** Bug 340842 has been marked as a duplicate of this bug. ***
Comment 10•18 years ago
|
||
here's a list of all the lines i find objectionable for that function: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp&rev=1.77&mark=251,254,257,273,278,285,287-288#245
first, one shouldn't claim to have inited until the end. second all the assertions are bogus and should be handled. but of course the patch posted would fix the average crash.
Reporter | ||
Updated•18 years ago
|
Assignee: bryner → nobody
Comment 11•18 years ago
|
||
This was fixed by bug 221634.
Assignee: nobody → michael.wu
Whiteboard: [checkin needed]
Updated•18 years ago
|
Assignee | ||
Comment 12•18 years ago
|
||
*** Bug 333115 has been marked as a duplicate of this bug. ***
Updated•16 years ago
|
Product: Firefox → Toolkit
Updated•13 years ago
|
Crash Signature: [@ nsPasswordManager::Init]
You need to log in
before you can comment on or make changes to this bug.
Description
•