294306 - CSS property text-indent doesn't work if image is a floated child of a paragraph

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[justin]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.7) Gecko/20050421 Firefox/1.0.3 (Debian package 1.0.3-2)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.7) Gecko/20050421 Firefox/1.0.3 (Debian package 1.0.3-2)

In the code attached to this bug report, the paragraph indents properly if the
floated image is a sibling of the paragraph but not as a child. To see what the
expected result is, comment out the first <p> and enable the second <p> tag.
Disregard the paragraph text. It is only included in order to make the float
obvious and as a reference point for indentation when it is rendered.

This has been tested in the most recent Linux and Windows version of Firefox as
well as the most recent Linux version of Mozilla using the XHTML 1.0 Strict and
XHTML 1.1 DTDs.

Reproducible: Always

Steps to Reproduce:
1. Create an (X)HTML file containing the code included in the details of this
bug report.
2. Replace test.jpg with a suitable test image.
3. View the (X)HTML file with Firefox or Mozilla(It is suspected that the same
bug will crop up when viewed on a browser based on the Gecko rendering engine).
Actual Results:  
The paragraph is not indented.

Expected Results:  
The paragraph should be indented.

Comment 1

[justin]

Attachment: A test case of a floated image as a child of a paragraph.

Comment 2

[Andrew Schultz]

this is one of the cases described in bug 159403

Comment 3

[justin]

(In reply to comment #2)
> this is one of the cases described in bug 159403

Oh... Sorry. I guess my search keywords were too narrow and i didn't find that.
I really don't know if I should mark this as a duplicate or just leave it as a
dependency. I guess I'll leave that up to you guys. Thanks.

Comment 4

[Andrew Schultz]

It's ok to leave this open.  bug 159403 was originally for a similar but
different issue that works now.  It's good to keep each different bug in a
separate bug report.

Comment 5

[Boris Zbarsky [:bzbarsky]]

So the basic issue here is that our line box effectively extends under the
float, right?

Comment 6

[Adam Guthrie]

*** Bug 321714 has been marked as a duplicate of this bug. ***

Comment 7

[Samuel Sidler (old account; do not CC)]

*** Bug 323896 has been marked as a duplicate of this bug. ***

Comment 8

[Chris Lawson (gone)]

FWIW, Apple's recently released iWeb software creates HTML/CSS that has this problem. See the bug that Sam duped here for more info. Possibly more important to fix this now that there's commercial software generating problematic (for us) code.

cl

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Works for me.  Maybe fixed by new text frame?

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(on a mozilla-central Linux build from yesterday)

Comment 11

[Stanimir Stamenkov]

Using 1.9.1a1pre nightly from yesterday, appears to be fixed but the 5th example from Bug 159403 Attachment 146914 [details] is not rendered as expected.  Looking at the example further I'm not sure it is valid/correct as Opera doesn't indent the anonymous block there, too.  Safari and IE do indent it, however.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Given when this started working, looks like this got fixed by the patch for bug 50630.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Checked in a test for this.