294342 - using tabbrowser inside xulrunner without setting prefs throws exceptions

Status: RESOLVED INVALID

(Toolkit Graveyard :: XULRunner, defect)

Description

[Clovis Wichoski]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

using tabbrowser inside xulrunner I get follow exception:
Error: [Exception... "Component returned failure code: 0x8000ffff
(NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]"  nsresult: "0x8000ffff
(NS_ERROR_UNEXPECTED)"  location: "JS frame ::
chrome://global/content/bindings/tabbrowser.xml :: shouldLoadFavIcon :: line
431"  data: no]
Source File: chrome://global/content/bindings/tabbrowser.xml
Line: 431

Reproducible: Always

Steps to Reproduce:
1. put a tabbrowser inside the of your main.xul
2. onload we get the exception


Actual Results:  
the application starts, but get exceptions,

Expected Results:  
application starts, but don´t get exceptions, or say to developer, please set
defaults prefs to use tabbrowser or whatever else.

Comment 1

[Clovis Wichoski]

the page that I loaded inside tabbrowser is in chrome:// url

Comment 2

[Darin Fisher]

Yeah, I ran into this problem as well while developing the "MyBrowser" XUL app:
http://friedfish.homeip.net/~darinf/xulrunner/mybrowser.html

I think we want to make tabbrowser support undefined prefs or we should move the
pref definitions into xulrunner.js (or some other prefs file included with
xulrunner).

Comment 3

[Alex Vincent [:WeirdAl]]

Supporting undefined prefs is a better solution, overall, imho.  Do you want a
patch from me?

Comment 4

[Benjamin Smedberg]

We probably want both solutions... in any case a patch is quite welcome.

Comment 5

[Alex Vincent [:WeirdAl]]

One small problem:

browser.chrome.favicons defaults to true for Firefox, but false for SeaMonkey
and for Thunderbird.

What should it be for XULRunner?

browser.chrome.site_icons is true for Firefox, SeaMonkey and Thunderbird, so
unless you say otherwise, I'm assuming you want that one true.

Comment 6

[Alex Vincent [:WeirdAl]]

bsmedberg, could you answer comment 5?

Also, this bug itself could become moot, if tabbrowser is removed from toolkit (which I believe is intended).

Comment 7

[Benjamin Smedberg]

AJ, I don't really care. As long as the prefs get overridden properly in the app-level prefs file, we'll be ok.

Comment 8

[Alex Vincent [:WeirdAl]]

asqueela, why is this INVALID?

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #8)
> asqueela, why is this INVALID?
> 

IIRC, tabbrowser.xml is not part of toolkit anymore

Comment 10

[Nickolay_Ponomarev]

>tabbrowser.xml is not part of toolkit anymore

Exactly. Sorry about closing without a comment; I thought I said it earlier in the bug.