Saved Searches properties has wrong title/description

VERIFIED FIXED

Status

MailNews Core
Filters
VERIFIED FIXED
13 years ago
10 years ago

People

(Reporter: Ian Neal, Assigned: whimboo)

Tracking

({regression})

Trunk
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
When you look at the properties of a saved search / virtual folder the dialog
box that comes up has the title "New Saved Search Folder" and the description
for the search criteria is "Configure the search criteria used for this virtual
folder" instead of "Modify the search criteria used for this saved search"
Created attachment 188026 [details] [diff] [review]
patch using document.title instead of window.title (Checked in)

Ok, this bug is caused by bug 264102. window.title is deprecated. Instead
document.title has to be used.
Assignee: mail → hskupin
Status: NEW → ASSIGNED
Attachment #188026 - Flags: review?(mnyromyr)
Depends on: 264102
Keywords: regression
Thunderbird uses the same code.

=> Core
Component: MailNews: Main Mail Window → MailNews: Filters
Product: Mozilla Application Suite → Core

Updated

13 years ago
Attachment #188026 - Flags: review?(mnyromyr) → review+
Comment on attachment 188026 [details] [diff] [review]
patch using document.title instead of window.title (Checked in)

Neil, this patch will fix your mentioned problem in not updating the title when
editing an existing saved search.
Attachment #188026 - Flags: superreview?(neil.parkwaycc.co.uk)

Comment 4

13 years ago
JFTR: this bug was spun off from bug 293682 initially.

Comment 5

13 years ago
Comment on attachment 188026 [details] [diff] [review]
patch using document.title instead of window.title (Checked in)

sr=dmose
Attachment #188026 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Attachment #188026 - Flags: approval1.8b3?

Updated

13 years ago
Attachment #188026 - Flags: approval1.8b3? → approval1.8b3+
(Reporter)

Comment 6

13 years ago
Comment on attachment 188026 [details] [diff] [review]
patch using document.title instead of window.title (Checked in)

Checking in virtualFolderProperties.js;
new revision: 1.12; previous revision: 1.11
done
Attachment #188026 - Attachment description: patch using document.title instead of window.title → patch using document.title instead of window.title (Checked in)
(Reporter)

Updated

13 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Verified with SeaMonkey 1.0a Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2)
Gecko/20050702 SeaMonkey/1.0a and Thunderbird version 1.0+ (20050702)
Status: RESOLVED → VERIFIED
I can confirm both the wrong title and wrong search criteria (none criteria), as if creating a new search.
There is also no checked folder to search.


Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060429 SeaMonkey/1.5a
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 9

12 years ago
This is not the same problem, I have opened bug 336100 on this new problem.
Status: REOPENED → RESOLVED
Last Resolved: 13 years ago12 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.