294555 - unexported api calls in p12plcy.h

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Jason Reid]

The following api calls in p12plcy.h are not found in a .def file.

SEC_PKCS12DecryptionAllowed NOT exported
SEC_PKCS12GetPreferredEncryptionAlgorithm NOT exported
SEC_PKCS12GetStrongestAllowedAlgorithm NOT exported

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

So, we need to decide: are these functions intended to be "public"? 

then if so, we need to add them to the relevant .def file,
and if not, we need to move these declarations to another file, or 
enclose them in an #ifdef with some symbol like PKCS12_private.

Comment 2

[Julien Pierre]

Retargetting all P2s to 3.11.3 .

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

All 3 functions are defined in p12plcy.c
They are not the only external functions in p12plcy.c
so we cannot remove that source file, but we can remove the
definition of those functions from the source file.

Comment 4

[Neil Williams]

Attachment: remove unused functions, export one

The 2 Get* functions are not used anywhere except in dead pkcs12 lib code. A separate bug will be opened about that. SEC_PKCS12DecryptionAllowed is used in pk12util.

Comment 5

[Neil Williams]

Checking in nss/lib/pkcs12/p12plcy.c;
/cvsroot/mozilla/security/nss/lib/pkcs12/p12plcy.c,v  <--  p12plcy.c
new revision: 1.7; previous revision: 1.6
done
Checking in nss/lib/pkcs12/p12plcy.h;
/cvsroot/mozilla/security/nss/lib/pkcs12/p12plcy.h,v  <--  p12plcy.h
new revision: 1.4; previous revision: 1.3
done
Checking in nss/lib/smime/smime.def;
/cvsroot/mozilla/security/nss/lib/smime/smime.def,v  <--  smime.def
new revision: 1.34; previous revision: 1.33
done