294556 - unexported api calls in pk11pub.h

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Jason Reid]

The following api calls in pk11pub.h are not found in a .def file.

PK11_GetPrevtGenericObject NOT exported
SECMOD_HasRootCerts NOT exported

Comment 1

[Robert Relyea]

One of these is a typo:
PK11_GetPrevtGenericObject should be: PK11_GetPrevGenericObject

The other is flat missing and should be added to nss.def

bob

Comment 2

[Robert Relyea]

Attachment: Update nss.def and pub.h to be consistant

Patch implements my comment.

Comment 3

[Wan-Teh Chang]

Comment on attachment 187141 [details] [diff] [review]
Update nss.def and pub.h to be consistant

>Index: nss/nss.def
>===================================================================
>RCS file: /cvsroot/mozilla/security/nss/lib/nss/nss.def,v
>retrieving revision 1.146
>diff -r1.146 nss.def
>852a853,859
>> ;+NSS_3.10 { 	# NSS 3.10 release
>> ;+    global:
>> SECMOD_HasRootCerts;

This should be NSS_3.10.1 because there is already a
NSS_3.10 section (added in the NSS 3.10 release).

Comment 4

[Robert Relyea]

Attachment: Update nss.def and pub.h to be consistant

This patch is targetting 3.11. Unless someone really needs it in a point
release of 3.10. (Good catch Wan-Teh

Comment 5

[Wan-Teh Chang]

Comment on attachment 187155 [details] [diff] [review]
Update nss.def and pub.h to be consistant

r=wtc.	Targetting 3.11 is fine by me.	You'll need
to wait until we have created the NSS_3_10_BRANCH
to check in this patch on the trunk.

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 187155 [details] [diff] [review]
Update nss.def and pub.h to be consistant

Agreed for 3.11 target.

Comment 7

[Robert Relyea]

Checking in nss/nss.def;
/cvsroot/mozilla/security/nss/lib/nss/nss.def,v  <--  nss.def
new revision: 1.148; previous revision: 1.147
done
Checking in pk11wrap/pk11pub.h;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11pub.h,v  <--  pk11pub.h
new revision: 1.7; previous revision: 1.6
done